Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1924753002: Revert of Added navigator.actions.share experimental web API (stub). (Closed)

Created:
4 years, 7 months ago by Matt Giuca
Modified:
4 years, 7 months ago
Reviewers:
Sam McNally, Mike West
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, chrome-apps-syd-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, kinuko+watch, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added navigator.actions.share experimental web API (stub). (patchset #19 id:460001 of https://codereview.chromium.org/1806253002/ ) Reason for revert: The LayoutTests added by this CL are failing on Mac bots. BUG=607086 Original issue's description: > Added navigator.actions.share experimental web API (stub). > > Requires the enable-experimental-web-platform-features flag. Currently > does nothing; future CLs will implement this on Android as an > experiment. > > BUG=595608 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675 > Cr-Commit-Position: refs/heads/master@{#390004} TBR=mkwst@chromium.org,sammc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595608 Committed: https://crrev.com/dd70f8bd8dec6675360f79b1cdfcc8c98e87053c Cr-Commit-Position: refs/heads/master@{#390009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -426 lines) Patch
D third_party/WebKit/LayoutTests/ballista/resources/mock-ballista-service.js View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/ballista/share-arity.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/ballista/share-error.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/ballista/share-success.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/ballista/share-types.html View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/modules/ballista/Actions.h View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/Source/modules/ballista/Actions.cpp View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/WebKit/Source/modules/ballista/Actions.idl View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/modules/ballista/NavigatorActions.h View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/modules/ballista/NavigatorActions.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/Source/modules/ballista/NavigatorActions.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/modules/ballista/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/public/platform/modules/ballista/OWNERS View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/public/platform/modules/ballista/ballista.mojom View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Matt Giuca
Created Revert of Added navigator.actions.share experimental web API (stub).
4 years, 7 months ago (2016-04-27 07:15:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924753002/1
4 years, 7 months ago (2016-04-27 07:15:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 07:17:26 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 07:18:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd70f8bd8dec6675360f79b1cdfcc8c98e87053c
Cr-Commit-Position: refs/heads/master@{#390009}

Powered by Google App Engine
This is Rietveld 408576698