Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1924743005: Move away from deprecated base::Value methods in //ui (Closed)

Created:
4 years, 7 months ago by dcheng
Modified:
4 years, 7 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, Matt Giuca, tapted, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move away from deprecated base::Value methods in //ui BUG=581865 Committed: https://crrev.com/60094aec2f382af40e59d7bb9fb8082729bfe357 Cr-Commit-Position: refs/heads/master@{#390295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M ui/app_list/search/dictionary_data_store.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/app_list/search/history_data_store.cc View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
4 years, 7 months ago (2016-04-27 22:58:38 UTC) #2
Matt Giuca
lgtm
4 years, 7 months ago (2016-04-28 03:50:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924743005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924743005/1
4 years, 7 months ago (2016-04-28 03:50:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 03:54:38 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:16:05 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/60094aec2f382af40e59d7bb9fb8082729bfe357
Cr-Commit-Position: refs/heads/master@{#390295}

Powered by Google App Engine
This is Rietveld 408576698