Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1924743004: Remove GYP build from bots and 'gclient runhooks' (Closed)

Created:
4 years, 7 months ago by Roland McGrath
Modified:
4 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Remove GYP build from bots and 'gclient runhooks' This starts the process of eliminating the GYP build of standalone NaCl. This doesn't touch any .gyp or .gypi files, most of which are still used in the Chromium build (which still needs to support GYP for a little while longer). It removes the GYP-related steps from the bot runs, and removes the machinery for running GYP manually or via gclient. BUG= none TEST= trybots R=dschuff@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/eec7648b9878417ea4f9f9628cf3340bd584bb5d

Patch Set 1 #

Patch Set 2 : git cl try #

Patch Set 3 : fix python lossage #

Patch Set 4 : remove stale imports #

Patch Set 5 : pnacl script #

Patch Set 6 : install sysroot in buildbot script #

Patch Set 7 : punt gyp build from pnacl script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -285 lines) Patch
M DEPS View 1 1 chunk +0 lines, -6 lines 0 comments Download
D build/gyp_nacl View 1 chunk +0 lines, -56 lines 0 comments Download
D build/gyp_nacl.py View 1 chunk +0 lines, -19 lines 0 comments Download
M buildbot/buildbot_lib.py View 6 chunks +12 lines, -45 lines 0 comments Download
M buildbot/buildbot_pnacl.py View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M buildbot/buildbot_pnacl.sh View 1 2 3 4 5 6 3 chunks +1 line, -53 lines 0 comments Download
M buildbot/buildbot_selector.py View 2 chunks +4 lines, -13 lines 0 comments Download
M buildbot/buildbot_standard.py View 1 2 3 4 5 7 chunks +25 lines, -90 lines 0 comments Download
M buildbot/buildbot_toolchain_build.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Roland McGrath
PTAL Derek, please confirm that the pnacl bot changes are OK. AFAICT the GYP builds ...
4 years, 7 months ago (2016-04-28 19:49:09 UTC) #2
Derek Schuff
On 2016/04/28 19:49:09, Roland McGrath wrote: > PTAL > > Derek, please confirm that the ...
4 years, 7 months ago (2016-04-28 19:57:14 UTC) #3
Roland McGrath
4 years, 7 months ago (2016-04-28 20:07:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #7 (id:110001) manually as
eec7648b9878417ea4f9f9628cf3340bd584bb5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698