Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1924743002: [debugger] remove some dead code. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] remove some dead code. The change removes threading information from the JSON debug API, which is deprecated anyways. R=cbruni@chromium.org Committed: https://crrev.com/3ef2f7a8c57a272f05e21332410e8e860bc5510d Cr-Commit-Position: refs/heads/master@{#35821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -153 lines) Patch
M src/debug/debug.js View 3 chunks +0 lines, -27 lines 0 comments Download
M src/debug/mirrors.js View 1 chunk +0 lines, -5 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/runtime/runtime-debug.cc View 2 chunks +0 lines, -116 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 8 months ago (2016-04-27 06:48:05 UTC) #1
Camillo Bruni
lgtm
4 years, 7 months ago (2016-04-27 11:48:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924743002/1
4 years, 7 months ago (2016-04-27 11:59:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 12:41:54 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 12:42:18 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3ef2f7a8c57a272f05e21332410e8e860bc5510d
Cr-Commit-Position: refs/heads/master@{#35821}

Powered by Google App Engine
This is Rietveld 408576698