Source/core/dom/Document.cpp - Issue 192473003: Move CSSRuleList to the garbage collected heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 192473003: Move CSSRuleList to the garbage collected heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Feedback from Haraken-san Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index f12e57867810d217ab1d1453594fd8c6fa8c2af4..d8e95cfa40e291b5308cc90f4ccb39d50d0fb7f6 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -556,7 +556,9 @@ Document::~Document()

m_timeline->detachFromDocument();

m_transitionTimeline->detachFromDocument();

- m_styleEngine.clear(); // We need to destory CSSFontSelector before destroying m_fetcher.

+ // We need to destroy CSSFontSelector before destroying m_fetcher.

+ if (m_styleEngine)

+ m_styleEngine->detachFromDocument();

if (m_elemSheet)

m_elemSheet->clearOwnerNode();