Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: Source/core/css/CSSImportRule.cpp

Issue 192473003: Move CSSRuleList to the garbage collected heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Feedback from Haraken-san Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSImportRule.cpp
diff --git a/Source/core/css/CSSImportRule.cpp b/Source/core/css/CSSImportRule.cpp
index a552f7b9560a87ea6a8dc330c7c0c5684ffae14b..2192f74227005aab62c0796781d71348f22a3c1e 100644
--- a/Source/core/css/CSSImportRule.cpp
+++ b/Source/core/css/CSSImportRule.cpp
@@ -38,8 +38,6 @@ CSSImportRule::CSSImportRule(StyleRuleImport* importRule, CSSStyleSheet* parent)
CSSImportRule::~CSSImportRule()
{
- if (m_styleSheetCSSOMWrapper)
Mads Ager (chromium) 2014/03/12 12:24:42 I think you still need this when !ENABLE(OILPAN).
Erik Corry 2014/03/12 12:31:27 Done.
- m_styleSheetCSSOMWrapper->clearOwnerRule();
#if !ENABLE(OILPAN)
// MediaList and the parent CSSImportRule are both on the oilpan heap and die together.
// Therefor clearing is not needed nor allowed since it could be touching already
@@ -100,6 +98,7 @@ void CSSImportRule::trace(Visitor* visitor)
{
visitor->trace(m_importRule);
visitor->trace(m_mediaCSSOMWrapper);
+ visitor->trace(m_styleSheetCSSOMWrapper);
CSSRule::trace(visitor);
}

Powered by Google App Engine
This is Rietveld 408576698