Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: Source/core/dom/Document.cpp

Issue 192473003: Move CSSRuleList to the garbage collected heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix teardown of StyleEngine Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index f12e57867810d217ab1d1453594fd8c6fa8c2af4..d8e95cfa40e291b5308cc90f4ccb39d50d0fb7f6 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -556,7 +556,9 @@ Document::~Document()
m_timeline->detachFromDocument();
m_transitionTimeline->detachFromDocument();
- m_styleEngine.clear(); // We need to destory CSSFontSelector before destroying m_fetcher.
+ // We need to destroy CSSFontSelector before destroying m_fetcher.
+ if (m_styleEngine)
+ m_styleEngine->detachFromDocument();
haraken 2014/03/12 11:08:21 Don't you need to clear m_styleEngine after callin
Erik Corry 2014/03/12 11:48:57 The clearing was just to deref it, as I understand
if (m_elemSheet)
m_elemSheet->clearOwnerNode();

Powered by Google App Engine
This is Rietveld 408576698