Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: Source/core/css/StyleSheetList.cpp

Issue 192473003: Move CSSRuleList to the garbage collected heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: ager feedback Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/StyleSheetList.h ('k') | Source/core/css/resolver/StyleResolver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2006, 2007 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2006, 2007 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 22 matching lines...) Expand all
33 33
34 StyleSheetList::StyleSheetList(TreeScope* treeScope) 34 StyleSheetList::StyleSheetList(TreeScope* treeScope)
35 : m_treeScope(treeScope) 35 : m_treeScope(treeScope)
36 { 36 {
37 } 37 }
38 38
39 StyleSheetList::~StyleSheetList() 39 StyleSheetList::~StyleSheetList()
40 { 40 {
41 } 41 }
42 42
43 inline const Vector<RefPtr<StyleSheet> >& StyleSheetList::styleSheets() 43 inline const WillBeHeapVector<RefPtrWillBeMember<StyleSheet> >& StyleSheetList:: styleSheets()
44 { 44 {
45 if (!m_treeScope) 45 if (!m_treeScope)
46 return m_detachedStyleSheets; 46 return m_detachedStyleSheets;
47 return document()->styleEngine()->styleSheetsForStyleSheetList(*m_treeScope) ; 47 return document()->styleEngine()->styleSheetsForStyleSheetList(*m_treeScope) ;
48 } 48 }
49 49
50 void StyleSheetList::detachFromDocument() 50 void StyleSheetList::detachFromDocument()
51 { 51 {
52 m_detachedStyleSheets = document()->styleEngine()->styleSheetsForStyleSheetL ist(*m_treeScope); 52 m_detachedStyleSheets = document()->styleEngine()->styleSheetsForStyleSheetL ist(*m_treeScope);
53 m_treeScope = 0; 53 m_treeScope = 0;
54 } 54 }
55 55
56 unsigned StyleSheetList::length() 56 unsigned StyleSheetList::length()
57 { 57 {
58 return styleSheets().size(); 58 return styleSheets().size();
59 } 59 }
60 60
61 StyleSheet* StyleSheetList::item(unsigned index) 61 StyleSheet* StyleSheetList::item(unsigned index)
62 { 62 {
63 const Vector<RefPtr<StyleSheet> >& sheets = styleSheets(); 63 const WillBeHeapVector<RefPtrWillBeMember<StyleSheet> >& sheets = styleSheet s();
64 return index < sheets.size() ? sheets[index].get() : 0; 64 return index < sheets.size() ? sheets[index].get() : 0;
65 } 65 }
66 66
67 HTMLStyleElement* StyleSheetList::getNamedItem(const AtomicString& name) const 67 HTMLStyleElement* StyleSheetList::getNamedItem(const AtomicString& name) const
68 { 68 {
69 if (!m_treeScope) 69 if (!m_treeScope)
70 return 0; 70 return 0;
71 71
72 // IE also supports retrieving a stylesheet by name, using the name/id of th e <style> tag 72 // IE also supports retrieving a stylesheet by name, using the name/id of th e <style> tag
73 // (this is consistent with all the other collections) 73 // (this is consistent with all the other collections)
74 // ### Bad implementation because returns a single element (are IDs always u nique?) 74 // ### Bad implementation because returns a single element (are IDs always u nique?)
75 // and doesn't look for name attribute. 75 // and doesn't look for name attribute.
76 // But unicity of stylesheet ids is good practice anyway ;) 76 // But unicity of stylesheet ids is good practice anyway ;)
77 // FIXME: We should figure out if we should change this or fix the spec. 77 // FIXME: We should figure out if we should change this or fix the spec.
78 Element* element = m_treeScope->getElementById(name); 78 Element* element = m_treeScope->getElementById(name);
79 return isHTMLStyleElement(element) ? toHTMLStyleElement(element) : 0; 79 return isHTMLStyleElement(element) ? toHTMLStyleElement(element) : 0;
80 } 80 }
81 81
82 CSSStyleSheet* StyleSheetList::anonymousNamedGetter(const AtomicString& name) 82 CSSStyleSheet* StyleSheetList::anonymousNamedGetter(const AtomicString& name)
83 { 83 {
84 HTMLStyleElement* item = getNamedItem(name); 84 HTMLStyleElement* item = getNamedItem(name);
85 if (!item) 85 if (!item)
86 return 0; 86 return 0;
87 return item->sheet(); 87 return item->sheet();
88 } 88 }
89 89
90 void StyleSheetList::trace(Visitor* visitor) 90 void StyleSheetList::trace(Visitor* visitor)
91 { 91 {
92 visitor->trace(m_detachedStyleSheets);
92 } 93 }
93 94
94 } // namespace WebCore 95 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/StyleSheetList.h ('k') | Source/core/css/resolver/StyleResolver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698