Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger-into-session
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
index cbe74c6ab83c02a874b7ba0e205cd5b4efb29255..c8cc8237bb5c3d2faebec8b6072eb7d61cf41fbb 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
@@ -44,12 +44,12 @@ public:
void reset();
void discardInjectedScripts();
void reportAllContexts(V8RuntimeAgentImpl*);
- void releaseObjectGroup(const String16& objectGroup);
void setCustomObjectFormatterEnabled(bool);
void changeInstrumentationCounter(int delta);
// V8InspectorSession implementation.
void setClient(V8InspectorSessionClient*) override;
+ void addInspectedObject(PassOwnPtr<V8InspectorSession::Inspectable>) override;
V8DebuggerAgent* debuggerAgent() override;
V8HeapProfilerAgent* heapProfilerAgent() override;
V8ProfilerAgent* profilerAgent() override;
@@ -64,9 +64,12 @@ public:
void asyncTaskStarted(void* task) override;
void asyncTaskFinished(void* task) override;
void allAsyncTasksCanceled() override;
+ void releaseObjectGroup(const String16& objectGroup) override;
+ v8::Local<v8::Value> findObject(ErrorString*, const String16& objectId, v8::Local<v8::Context>* = nullptr, String16* groupName = nullptr) override;
+ PassOwnPtr<protocol::Runtime::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName, bool generatePreview = false) override;
+ PassOwnPtr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Context>, v8::Local<v8::Value> table, v8::Local<v8::Value> columns) override;
- void addInspectedObject(PassOwnPtr<V8RuntimeAgent::Inspectable>);
- V8RuntimeAgent::Inspectable* inspectedObject(unsigned num);
+ V8InspectorSession::Inspectable* inspectedObject(unsigned num);
static const unsigned kInspectedObjectBufferSize = 5;
private:
@@ -82,7 +85,7 @@ private:
OwnPtr<V8DebuggerAgentImpl> m_debuggerAgent;
OwnPtr<V8HeapProfilerAgentImpl> m_heapProfilerAgent;
OwnPtr<V8ProfilerAgentImpl> m_profilerAgent;
- protocol::Vector<OwnPtr<V8RuntimeAgent::Inspectable>> m_inspectedObjects;
+ protocol::Vector<OwnPtr<V8InspectorSession::Inspectable>> m_inspectedObjects;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698