Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger-into-session
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
index 0cc989f295d6e60694dce0c116d778f3f668dcd1..44a74433da436df7350df1298d8450c3d8ce9250 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
@@ -104,7 +104,7 @@ v8::Local<v8::Object> objectByHeapObjectId(v8::Isolate* isolate, int id)
return value.As<v8::Object>();
}
-class InspectableHeapObject final : public V8RuntimeAgent::Inspectable {
+class InspectableHeapObject final : public V8InspectorSession::Inspectable {
public:
explicit InspectableHeapObject(int heapObjectId) : m_heapObjectId(heapObjectId) { }
v8::Local<v8::Value> get(v8::Local<v8::Context> context) override
@@ -266,7 +266,7 @@ void V8HeapProfilerAgentImpl::getObjectByHeapObjectId(ErrorString* error, const
return;
}
- *result = m_session->runtimeAgent()->wrapObject(heapObject->CreationContext(), heapObject, objectGroup.fromMaybe(""));
+ *result = m_session->wrapObject(heapObject->CreationContext(), heapObject, objectGroup.fromMaybe(""));
if (!result)
*error = "Object is not available";
}
@@ -292,13 +292,13 @@ void V8HeapProfilerAgentImpl::addInspectedHeapObject(ErrorString* errorString, c
return;
}
- m_session->runtimeAgent()->addInspectedObject(adoptPtr(new InspectableHeapObject(id)));
+ m_session->addInspectedObject(adoptPtr(new InspectableHeapObject(id)));
}
void V8HeapProfilerAgentImpl::getHeapObjectId(ErrorString* errorString, const String16& objectId, String16* heapSnapshotObjectId)
{
v8::HandleScope handles(m_isolate);
- v8::Local<v8::Value> value = m_session->runtimeAgent()->findObject(errorString, objectId);
+ v8::Local<v8::Value> value = m_session->findObject(errorString, objectId);
if (value.IsEmpty() || value->IsUndefined())
return;

Powered by Google App Engine
This is Rietveld 408576698