third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp - Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger-into-session

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

index 51a682ddb0677cfc58a38b2e2f289340391c118f..be0f20b7c6765d3d186cb5e74dfc6756bb9b6720 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

@@ -623,7 +623,7 @@ void V8Console::inspectedObject(const v8::FunctionCallbackInfo<v8::Value>& info,

ASSERT(num < V8InspectorSessionImpl::kInspectedObjectBufferSize);

ConsoleHelper helper(info);

if (V8InspectorSessionImpl* session = helper.currentSession()) {

- V8RuntimeAgent::Inspectable* object = session->inspectedObject(num);

+ V8InspectorSession::Inspectable* object = session->inspectedObject(num);

v8::Isolate* isolate = info.GetIsolate();

if (object)

info.GetReturnValue().Set(object->get(isolate->GetCurrentContext()));