Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1924663004: Import web-platform-tests@c969f975ca64b67ebcdddfefa0ef1d7d82680d88 (Closed)

Created:
4 years, 7 months ago by dtapuska
Modified:
4 years, 7 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, Eric Willigers, jshin+watch_chromium.org, rjwright, shans, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import web-platform-tests@12528872c91a3996dce9053e5f8bcf2dddc54ec5 Using update-w3c-deps in Blink 1d491ec4d5956c60fbf72e8cb5d3b27c842f9e6b. Add expected tests for the tests that with reproducible failures instead of skipping them. BUG=606875, 606900, 606934, 607540 Committed: https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9 Cr-Commit-Position: refs/heads/master@{#390453}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add TestExpectations for web animations instead of skipping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8478 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/README.md View 1 chunk +7 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/encoding/textdecoder-fatal-single-byte.html View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/encoding/textdecoder-fatal-single-byte-expected.txt View 1 chunk +7322 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-with-cross-frame-event-listeners-1.html View 3 chunks +5 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-with-cross-frame-event-listeners-1-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-with-cross-frame-event-listeners-2.html View 3 chunks +5 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-with-cross-frame-event-listeners-2-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/shadow-dom/Document-prototype-adoptNode.html View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/shadow-dom/Document-prototype-importNode.html View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/shadow-dom/Node-prototype-cloneNode.html View 1 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/easing.html View 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/easing-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/fill.html View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/fill-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-model/animation-types/discrete-animation.html View 1 chunk +136 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-model/animation-types/discrete-animation-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-model/animation-types/not-animatable.html View 1 chunk +120 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-model/animation-types/not-animatable-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation/finished.html View 1 chunk +371 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation/finished-expected.txt View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation/oncancel.html View 1 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation/onfinish.html View 1 1 chunk +122 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
dtapuska
I've asked what tkent@ asked for in the CL from yesterday.
4 years, 7 months ago (2016-04-27 20:21:26 UTC) #3
jsbell
Can you file an issue for the encoding/textdecoder-fatal-single-byte.html failure? component=Blink>TextEncoding (since I care about those ...
4 years, 7 months ago (2016-04-27 20:27:33 UTC) #5
suzyh_UTC10 (ex-contributor)
https://codereview.chromium.org/1924663004/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/1924663004/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations#newcode771 third_party/WebKit/LayoutTests/W3CImportExpectations:771: imported/web-platform-tests/web-animations/animation/onfinish.html [ Skip ] In what way are these ...
4 years, 7 months ago (2016-04-27 21:59:05 UTC) #7
tkent
wpt/html looks good. thanks.
4 years, 7 months ago (2016-04-27 22:46:53 UTC) #8
jsbell
lgtm (just to get that on the record)
4 years, 7 months ago (2016-04-28 16:39:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924663004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924663004/20001
4 years, 7 months ago (2016-04-28 18:55:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 20:03:18 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:20:25 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9
Cr-Commit-Position: refs/heads/master@{#390453}

Powered by Google App Engine
This is Rietveld 408576698