Adding test generators to the Nexus 9 bot.

Adding test generators to the Nexus 9 bot.

Previously, the tests were not running on the Nexus 9 bot.
We believe this is because there were no test generators.
This should enable a handful of test generators, including telemetry ones.
But since there are no telemetry tests on that bot, those should effectively
be a noop.

BUG=606160
TBR=kbr@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300214

[cblume, 2016-04-26 21:35:39]

The CQ bit was checked by cblume@chromium.org

[commit-bot: I haz the power, 2016-04-26 21:35:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924653002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924653002/1

[commit-bot: I haz the power, 2016-04-26 21:35:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 21:35:51]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[jbudorick, 2016-04-26 21:38:23]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2016-04-26 21:38:23]

lgtm w/ nit

https://codereview.chromium.org/1924653002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py (right):

https://codereview.chromium.org/1924653002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py:762:
steps.generate_gtest,
nit: two-space indent

[cblume, 2016-04-26 22:03:24]

https://codereview.chromium.org/1924653002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py (right):

https://codereview.chromium.org/1924653002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py:762:
steps.generate_gtest,
On 2016/04/26 21:38:23, jbudorick wrote:
> nit: two-space indent

Done.

[cblume, 2016-04-26 22:03:28]

The CQ bit was checked by cblume@chromium.org

[cblume, 2016-04-26 22:03:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1924653002/#ps20001
(title: "Fixing two-space indents.")

[commit-bot: I haz the power, 2016-04-26 22:03:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924653002/20001

[commit-bot: I haz the power, 2016-04-26 22:29:28]

Description was changed from

==========
Adding test generators to the Nexus 9 bot.

Previously, the tests were not running on the Nexus 9 bot.
We believe this is because there were no test generators.
This should enable a handful of test generators, including telemetry ones.
But since there are no telemetry tests on that bot, those should effectively
be a noop.

BUG=606160
TBR=kbr@chromium.org
==========

to

==========
Adding test generators to the Nexus 9 bot.

Previously, the tests were not running on the Nexus 9 bot.
We believe this is because there were no test generators.
This should enable a handful of test generators, including telemetry ones.
But since there are no telemetry tests on that bot, those should effectively
be a noop.

BUG=606160
TBR=kbr@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300214
==========

[commit-bot: I haz the power, 2016-04-26 22:29:29]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300214

[Ken Russell (switch to Gerrit), 2016-04-27 08:47:02]

Thanks for tracking this down! LGTM after the fact.

[cblume, 2016-04-27 09:01:35]

On 2016/04/27 08:47:02, Ken Russell OOO till 5-2-2016 wrote:
> Thanks for tracking this down! LGTM after the fact.

Just as way of an update:
gl_tests and gl_unittests are failing on this bot because the script to run the
test on an Android device is being passed a command line argument.
The non-Android platforms need this command line argument.
I'm not sure if we can conditionally add it. I threw the idea around of having
gl_tests_android which wouldn't have the command line argument.
I'll make a PS for that tomorrow and see if we dislike it enough. I would rather
use is_android to make it a conditional argument if that is possible.

[Ken Russell (switch to Gerrit), 2016-04-27 09:44:00]

On 2016/04/27 09:01:35, cblume wrote:
> On 2016/04/27 08:47:02, Ken Russell OOO till 5-2-2016 wrote:
> > Thanks for tracking this down! LGTM after the fact.
> 
> Just as way of an update:
> gl_tests and gl_unittests are failing on this bot because the script to run
the
> test on an Android device is being passed a command line argument.
> The non-Android platforms need this command line argument.
> I'm not sure if we can conditionally add it. I threw the idea around of having
> gl_tests_android which wouldn't have the command line argument.
> I'll make a PS for that tomorrow and see if we dislike it enough. I would
rather
> use is_android to make it a conditional argument if that is possible.

I'm putting up a CL right now to fix this.