[Cronet] Do not call into BidirectionalStream::SendData if stream failed

[Cronet] Do not call into BidirectionalStream::SendData if stream failed

Cronet currently posts a task to the network thread to
write data to the stream. However, between the time when
the task is posted on Java thread and when the task is
executed on the network thread, the underlying
stream might have failed for some reason (e.g. server
terminated the connection). If that is the case,
we should not call into the stream.

Without this patch, when running the new unit test with
asan enabled, we will have a crash.

Review URL: https://codereview.chromium.org/1911353003

Cr-Commit-Position: refs/heads/master@{#389379}
(cherry picked from commit 943b9ad8edd8185defebc09d5917242122833cc4)

NOTRY=true
NOPRESUBMIT=true
TBR=kapishnikov@chromium.org

BUG=606394

[xunjieli, 2016-04-26 20:47:38]

xunjieli@chromium.org changed reviewers:
+ kapishnikov@chromium.org

[xunjieli, 2016-04-26 20:47:38]

Hi Andrei, this is to merge into M51. If possible, we should get this in by 5PM
PST to be included in this week's beta release. Thanks!

[xunjieli, 2016-04-26 20:47:51]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 20:48:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924623002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924623002/1

[commit-bot: I haz the power, 2016-04-26 20:48:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 20:48:29]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[xunjieli, 2016-04-26 20:49:33]

Description was changed from

==========
[Cronet] Do not call into BidirectionalStream::SendData if stream failed

Cronet currently posts a task to the network thread to
write data to the stream. However, between the time when
the task is posted on Java thread and when the task is
executed on the network thread, the underlying
stream might have failed for some reason (e.g. server
terminated the connection). If that is the case,
we should not call into the stream.

Without this patch, when running the new unit test with
asan enabled, we will have a crash.

Review URL: https://codereview.chromium.org/1911353003

Cr-Commit-Position: refs/heads/master@{#389379}
(cherry picked from commit 943b9ad8edd8185defebc09d5917242122833cc4)

BUG=606394
==========

to

==========
[Cronet] Do not call into BidirectionalStream::SendData if stream failed

Cronet currently posts a task to the network thread to
write data to the stream. However, between the time when
the task is posted on Java thread and when the task is
executed on the network thread, the underlying
stream might have failed for some reason (e.g. server
terminated the connection). If that is the case,
we should not call into the stream.

Without this patch, when running the new unit test with
asan enabled, we will have a crash.

Review URL: https://codereview.chromium.org/1911353003

Cr-Commit-Position: refs/heads/master@{#389379}
(cherry picked from commit 943b9ad8edd8185defebc09d5917242122833cc4)

TBR=kapishnikov@chromium.org

BUG=606394
==========

[xunjieli, 2016-04-26 20:49:37]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2016-04-26 20:50:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924623002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924623002/1

[commit-bot: I haz the power, 2016-04-26 20:50:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 20:50:07]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[xunjieli, 2016-04-26 20:56:44]

Description was changed from

==========
[Cronet] Do not call into BidirectionalStream::SendData if stream failed

Cronet currently posts a task to the network thread to
write data to the stream. However, between the time when
the task is posted on Java thread and when the task is
executed on the network thread, the underlying
stream might have failed for some reason (e.g. server
terminated the connection). If that is the case,
we should not call into the stream.

Without this patch, when running the new unit test with
asan enabled, we will have a crash.

Review URL: https://codereview.chromium.org/1911353003

Cr-Commit-Position: refs/heads/master@{#389379}
(cherry picked from commit 943b9ad8edd8185defebc09d5917242122833cc4)

TBR=kapishnikov@chromium.org

BUG=606394
==========

to

==========
[Cronet] Do not call into BidirectionalStream::SendData if stream failed

Cronet currently posts a task to the network thread to
write data to the stream. However, between the time when
the task is posted on Java thread and when the task is
executed on the network thread, the underlying
stream might have failed for some reason (e.g. server
terminated the connection). If that is the case,
we should not call into the stream.

Without this patch, when running the new unit test with
asan enabled, we will have a crash.

Review URL: https://codereview.chromium.org/1911353003

Cr-Commit-Position: refs/heads/master@{#389379}
(cherry picked from commit 943b9ad8edd8185defebc09d5917242122833cc4)

NOTRY=true
NOPRESUBMIT=true
TBR=kapishnikov@chromium.org

BUG=606394
==========

[xunjieli, 2016-04-26 20:56:50]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2016-04-26 20:57:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924623002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924623002/1

[commit-bot: I haz the power, 2016-04-26 21:03:40]

Description was changed from

==========
[Cronet] Do not call into BidirectionalStream::SendData if stream failed

Cronet currently posts a task to the network thread to
write data to the stream. However, between the time when
the task is posted on Java thread and when the task is
executed on the network thread, the underlying
stream might have failed for some reason (e.g. server
terminated the connection). If that is the case,
we should not call into the stream.

Without this patch, when running the new unit test with
asan enabled, we will have a crash.

Review URL: https://codereview.chromium.org/1911353003

Cr-Commit-Position: refs/heads/master@{#389379}
(cherry picked from commit 943b9ad8edd8185defebc09d5917242122833cc4)

NOTRY=true
NOPRESUBMIT=true
TBR=kapishnikov@chromium.org

BUG=606394
==========

to

==========
[Cronet] Do not call into BidirectionalStream::SendData if stream failed

Cronet currently posts a task to the network thread to
write data to the stream. However, between the time when
the task is posted on Java thread and when the task is
executed on the network thread, the underlying
stream might have failed for some reason (e.g. server
terminated the connection). If that is the case,
we should not call into the stream.

Without this patch, when running the new unit test with
asan enabled, we will have a crash.

Review URL: https://codereview.chromium.org/1911353003

Cr-Commit-Position: refs/heads/master@{#389379}
(cherry picked from commit 943b9ad8edd8185defebc09d5917242122833cc4)

NOTRY=true
NOPRESUBMIT=true
TBR=kapishnikov@chromium.org

BUG=606394
==========

[commit-bot: I haz the power, 2016-04-26 21:03:42]

Committed patchset #1 (id:1)

[kapishnikov, 2016-04-26 21:33:37]

LGTM!