Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1924593002: Do a null check in CronetURLRequestAdapter::GetStatusOnNetworkThread (Closed)

Created:
4 years, 8 months ago by xunjieli
Modified:
4 years, 7 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do a null check in CronetURLRequestAdapter::GetStatusOnNetworkThread A recent change made startInternal() asynchronous when there is an upload, if getStatus() is called right afterwards, we can get a native crash. This CL adds a null check and a regression test. BUG=606872 Committed: https://crrev.com/da26cb8e57a6d64ebf1f7d4e336aa6bbcdc2a189 Cr-Commit-Position: refs/heads/master@{#390079}

Patch Set 1 : #

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -2 lines) Patch
M components/cronet/android/cronet_url_request_adapter.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java View 1 2 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
xunjieli
Andrei, PTAL. Without the patch, the new test will result in a crash.
4 years, 8 months ago (2016-04-26 19:42:53 UTC) #4
xunjieli
Done. Thanks a lot for the very valuable test suggestion!
4 years, 8 months ago (2016-04-27 01:26:35 UTC) #6
kapishnikov
LGTM
4 years, 7 months ago (2016-04-27 14:24:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924593002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924593002/80001
4 years, 7 months ago (2016-04-27 14:27:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 7 months ago (2016-04-27 15:09:01 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 15:10:28 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da26cb8e57a6d64ebf1f7d4e336aa6bbcdc2a189
Cr-Commit-Position: refs/heads/master@{#390079}

Powered by Google App Engine
This is Rietveld 408576698