Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1924583002: Revert of depot_tools: add test_api to infra_paths recipe module (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of depot_tools: add test_api to infra_paths recipe module (patchset #1 id:1 of https://codereview.chromium.org/1915113006/ ) Reason for revert: breaks skia bots :( Original issue's description: > depot_tools: add test_api to infra_paths recipe module > > BUG=chromium:605919 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300191 TBR=machenbach@chromium.org,sergiyb@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:605919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -41 lines) Patch
M recipe_modules/infra_paths/api.py View 2 chunks +0 lines, -5 lines 0 comments Download
M recipe_modules/infra_paths/example.py View 2 chunks +1 line, -8 lines 0 comments Download
M recipe_modules/infra_paths/example.expected/linux.json View 1 chunk +0 lines, -4 lines 0 comments Download
M recipe_modules/infra_paths/example.expected/mac.json View 1 chunk +0 lines, -4 lines 0 comments Download
M recipe_modules/infra_paths/example.expected/win.json View 1 chunk +0 lines, -4 lines 0 comments Download
D recipe_modules/infra_paths/test_api.py View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tandrii(chromium)
Created Revert of depot_tools: add test_api to infra_paths recipe module
4 years, 8 months ago (2016-04-26 18:50:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924583002/1
4 years, 8 months ago (2016-04-26 18:50:38 UTC) #2
commit-bot: I haz the power
Failed to apply patch for recipe_modules/infra_paths/api.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
4 years, 8 months ago (2016-04-26 18:50:45 UTC) #4
Sergiy Byelozyorov
4 years, 7 months ago (2016-04-27 21:50:45 UTC) #5
Message was sent while issue was closed.
closed

Powered by Google App Engine
This is Rietveld 408576698