Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Unified Diff: tools/perf/benchmarks/memory_infra.py

Issue 1924553005: [Memory Health] Enable benchmark on Android One bots (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/memory_infra.py
diff --git a/tools/perf/benchmarks/memory_infra.py b/tools/perf/benchmarks/memory_infra.py
index 40f09ad89e465ad4fa468da18a3ba623007c9e1e..153147153a0ae893d307d5bdf4bff6f384d963c6 100644
--- a/tools/perf/benchmarks/memory_infra.py
+++ b/tools/perf/benchmarks/memory_infra.py
@@ -62,9 +62,9 @@ class MemoryHealthQuick(_MemoryInfra):
@classmethod
def ShouldDisable(cls, possible_browser):
- # Benchmark requires DeskClock app only available on Nexus devices.
- # See http://crbug.com/546842
- return 'nexus' not in possible_browser.platform.GetDeviceTypeName().lower()
+ # TODO(crbug.com/586148): Benchmark should not depend on DeskClock app.
+ return not possible_browser.platform.CanLaunchApplication(
+ 'com.google.android.deskclock')
# Benchmark is disabled by default because it takes too long to run.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698