Issue 1924523002: Upgrade v8.infinite_scroll and v8.mobile_infinite_scroll to TBMv2.

ulan

Description was changed from ========== Upgrade v8.infinite_scroll and v8.mobile_infinite_scroll to TBMv2. BUG=593793 ========== to ========== ...

4 years, 8 months ago (2016-04-26 18:01:53 UTC) #1

ulan

On 2016/04/26 18:06:21, nednguyen wrote: > lgtm > > Looks like we simplify a lot ...

4 years, 8 months ago (2016-04-26 18:17:40 UTC) #5

ulan

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the ...

4 years, 7 months ago (2016-04-28 15:23:10 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924523002/40001

4 years, 7 months ago (2016-04-28 15:23:21 UTC) #8

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 7 months ago (2016-04-28 20:33:44 UTC) #9

commit-bot: I haz the power

Try jobs failed on following builders: winx64_10_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_cq/builds/148)

4 years, 7 months ago (2016-04-28 20:33:45 UTC) #10

nednguyen

On 2016/04/28 20:33:45, commit-bot: I haz the power wrote: > Try jobs failed on following ...

4 years, 7 months ago (2016-04-28 23:50:45 UTC) #11

On 2016/04/28 20:33:45, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   winx64_10_perf_cq on tryserver.chromium.perf (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...)

Hmhhh, the failure looks legit:

[  FAILED  ] discourse (51609 ms)
(INFO) 2016-04-28 13:26:51,894
desktop_browser_backend._TryCooperativeShutdown:508  Successfully shut down
browser cooperatively
(INFO) 2016-04-28 13:26:53,003 exception_formatter.PrintFormattedException:19 
Try printing formatted exception: None None None

Traceback (most recent call last):
  RunBenchmark at
C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\telemetry\telemetry\internal\story_runner.py:312
    benchmark.ShouldTearDownStateAfterEachStoryRun())
  Run at
C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\telemetry\telemetry\internal\story_runner.py:225
    _RunStoryAndProcessErrorIfNeeded(story, results, state, test)
  _RunStoryAndProcessErrorIfNeeded at
C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\telemetry\telemetry\internal\story_runner.py:86
    test.Measure(state.platform, results)
  Measure at
C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\telemetry\telemetry\web_perf\timeline_based_measurement.py:280
    trace_value = trace.TraceValue(results.current_page, trace_result)
  __init__ at
C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\telemetry\telemetry\value\trace.py:35
    self._temp_file = self._GetTempFileHandle(trace_data)
  _GetTempFileHandle at
C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\telemetry\telemetry\value\trace.py:48
    content)
  WriteHTMLForTraceDataToFile at
C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\tracing\tracing_build\trace2html.py:95
    trace_data = json.dumps(trace_data)
  dumps at C:\b\depot_tools\python276_bin\lib\json\__init__.py:243
    return _default_encoder.encode(obj)
  encode at C:\b\depot_tools\python276_bin\lib\json\encoder.py:207
    chunks = self.iterencode(o, _one_shot=True)
  iterencode at C:\b\depot_tools\python276_bin\lib\json\encoder.py:270
    return _iterencode(o, 0)
MemoryError

Locals:
  _encoder    : <built-in function encode_basestring_ascii>
  _iterencode : <_json.Encoder object at 0x4AE71230>
  _one_shot   : True
  floatstr    : <function floatstr at 0x46F2A3F0>
(INFO) 2016-04-28 13:26:55,816 exception_formatter.PrintFormattedException:19 
Try printing formatted exception: <type 'exceptions.MemoryError'>  <traceback
object at 0x1345BA80>

Traceback (most recent call last):
  <module> at
C:\b\build\slave\winx64_10_perf_cq\build\src\tools\perf\run_benchmark:22
    sys.exit(main())
  main at
C:\b\build\slave\winx64_10_perf_cq\build\src\tools\perf\run_benchmark:19
    return benchmark_runner.main(config, [trybot_command.Trybot])
  main at
C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\telemetry\telemetry\benchmark_runner.py:412
    return command_instance.Run(options)
  Run at
C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\telemetry\telemetry\benchmark_runner.py:231
    return min(255, self._benchmark().Run(args))
  Run at
C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\telemetry\telemetry\benchmark.py:91
    return story_runner.RunBenchmark(self, finder_options)
  RunBenchmark at
C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\telemetry\telemetry\internal\story_runner.py:315
    exception_formatter.PrintFormattedException()
  PrintFormattedException at
C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\telemetry\telemetry\internal\util\exception_formatter.py:43
    _PrintFormattedTrace(processed_tb, frame, exception_string)
  _PrintFormattedTrace at
C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\telemetry\telemetry\internal\util\exception_formatter.py:78
    value = repr(value)
MemoryError


I am suspecting that the trace file is too big ~_~

Also Randy, can you look into:
(ERROR) 2016-04-28 13:24:05,992
tracing_controller_backend.CollectAgentTraceData:247  Error when deleting
c:\users\chrome~2\appdata\local\temp\tmpyaasvk, will try again at exit.
Traceback (most recent call last):
  File
"C:\b\build\slave\winx64_10_perf_cq\build\src\third_party\catapult\telemetry\telemetry\internal\platform\tracing_controller_backend.py",
line 243, in CollectAgentTraceData
    os.remove(self._trace_log)
WindowsError: [Error 32] The process cannot access the file because it is being
used by another process: 'c:\\users\\chrome~2\\appdata\\local\\temp\\tmpyaasvk'

I suspect that we are using the tempfile for trace but fail to close it before
cleaning up.

nednguyen

nednguyen@google.com changed reviewers: + rnephew@chromium.org

4 years, 7 months ago (2016-04-28 23:51:22 UTC) #12

ulan

I guess disable-by-default-v8 generates a lot events. For now I am going to land without ...

4 years, 7 months ago (2016-04-29 08:59:38 UTC) #14

ulan

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the ...

4 years, 7 months ago (2016-04-29 09:01:03 UTC) #16

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924523002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924523002/60001

4 years, 7 months ago (2016-04-29 09:01:25 UTC) #17

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 7 months ago (2016-04-29 10:17:35 UTC) #18

commit-bot: I haz the power

Try jobs failed on following builders: winx64_10_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_cq/builds/149)

4 years, 7 months ago (2016-04-29 10:17:36 UTC) #19

ulan

Argh, looks like unrelated compile error: Failed to find an input file: Input file C:\b\build\slave\winx64_10_perf_cq\build\src\out\Release_x64\mojo_public_test_support.dll ...

4 years, 7 months ago (2016-04-29 12:53:04 UTC) #20

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924523002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924523002/60001

4 years, 7 months ago (2016-04-29 12:53:22 UTC) #22

commit-bot: I haz the power

4 years, 7 months ago (2016-04-30 17:25:45 UTC) #24

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/48d11e43b2d31b519408b0a78528648528a91f5e
Cr-Commit-Position: refs/heads/master@{#390645}

commit-bot: I haz the power

4 years, 7 months ago (2016-04-30 18:00:35 UTC) #25

Message was sent while issue was closed.

Description was changed from

==========
Upgrade v8.infinite_scroll and v8.mobile_infinite_scroll to TBMv2.

BUG=593793
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

to

==========
Upgrade v8.infinite_scroll and v8.mobile_infinite_scroll to TBMv2.

BUG=593793
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Committed: https://crrev.com/48d11e43b2d31b519408b0a78528648528a91f5e
Cr-Commit-Position: refs/heads/master@{#390645}
==========

Issue 1924523002: Upgrade v8.infinite_scroll and v8.mobile_infinite_scroll to TBMv2. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase and fixes #

Patch Set 4 : Remove disabled-by-default-v8 #

Messages