Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1594)

Issue 1924483002: S390: [Interpreter] Use FastNewSloppyArguments when possible. (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [Interpreter] Use FastNewSloppyArguments when possible. Port c005029aa47f6e27d50e92a70f526f1651b18553 Original commit message: Use the FastNewSloppyArgumentsStub in the interpreter when function doesn't have duplicate parameters. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/f356efcf625c58f37841dc0d484f33c3d8a903d5 Cr-Commit-Position: refs/heads/master@{#35803}

Patch Set 1 #

Patch Set 2 : remove blank lines and add kNear #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M src/s390/code-stubs-s390.cc View 1 3 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 7 months ago (2016-04-26 17:46:21 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924483002/20001
4 years, 7 months ago (2016-04-26 18:33:27 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-26 19:04:26 UTC) #5
JoranSiu
On 2016/04/26 19:04:26, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 7 months ago (2016-04-26 20:40:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924483002/20001
4 years, 7 months ago (2016-04-27 03:38:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 03:41:27 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 03:43:31 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f356efcf625c58f37841dc0d484f33c3d8a903d5
Cr-Commit-Position: refs/heads/master@{#35803}

Powered by Google App Engine
This is Rietveld 408576698