content/public/test/mock_download_manager.h - Issue 1924473003: [Downloads] Use the initiating StoragePartition for resumption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/mock_download_manager.h

Issue 1924473003: [Downloads] Use the initiating StoragePartition for resumption. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ordering of site_instance_url/SiteInstanceURL fields, and add history test for WebViewTest. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/download_url_parameters.cc ('K') | « content/public/test/mock_download_item.h ('k') | content/public/test/mock_download_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/mock_download_manager.h

diff --git a/content/public/test/mock_download_manager.h b/content/public/test/mock_download_manager.h

index 1ccc70d9d3608811038ebc7d4bf3b664797e3b0a..2770ddfda74bc7e4417367dc3d8a8efe3252b979 100644

--- a/content/public/test/mock_download_manager.h

+++ b/content/public/test/mock_download_manager.h

@@ -36,6 +36,7 @@ class MockDownloadManager : public DownloadManager {

base::FilePath target_path;

std::vector<GURL> url_chain;

GURL referrer_url;

+ GURL site_instance_url;

GURL tab_url;

GURL tab_referrer_url;

std::string mime_type;

@@ -58,6 +59,7 @@ class MockDownloadManager : public DownloadManager {

const base::FilePath& target_path,

const std::vector<GURL>& url_chain,

const GURL& referrer_url,

+ const GURL& site_instance_url,

const GURL& tab_url,

const GURL& tab_refererr_url,

const std::string& mime_type,

@@ -117,6 +119,7 @@ class MockDownloadManager : public DownloadManager {

const base::FilePath& target_path,

const std::vector<GURL>& url_chain,

const GURL& referrer_url,

+ const GURL& site_instance_ur,

Charlie Reis 2016/05/05 21:43:23 Typo (missing "l"). Also, should be site_url like

asanka 2016/05/07 00:24:45 Done :)

const GURL& tab_url,

const GURL& tab_refererr_url,

const std::string& mime_type,

« content/public/browser/download_url_parameters.cc ('K') | « content/public/test/mock_download_item.h ('k') | content/public/test/mock_download_manager.cc » ('j') | no next file with comments »