Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: content/public/browser/download_item.h

Issue 1924473003: [Downloads] Use the initiating StoragePartition for resumption. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix ordering of site_instance_url/SiteInstanceURL fields, and add history test for WebViewTest. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/download_item.h
diff --git a/content/public/browser/download_item.h b/content/public/browser/download_item.h
index 6182cd4185b6e38e4bb511dd3fe834d3f5fecd30..38164bf6687e918742e90ec60906278e5ad5f62f 100644
--- a/content/public/browser/download_item.h
+++ b/content/public/browser/download_item.h
@@ -192,6 +192,7 @@ class CONTENT_EXPORT DownloadItem : public base::SupportsUserData {
virtual const std::vector<GURL>& GetUrlChain() const = 0;
virtual const GURL& GetOriginalUrl() const = 0;
virtual const GURL& GetReferrerUrl() const = 0;
+ virtual const GURL& GetSiteInstanceUrl() const = 0;
Charlie Reis 2016/05/05 21:43:22 This should really be GetSiteURL. SiteInstance is
ncarter (slow) 2016/05/05 23:29:07 Agree that this is safe.
asanka 2016/05/07 00:24:45 Cool. Thanks. I added a comment here and changed t
virtual const GURL& GetTabUrl() const = 0;
virtual const GURL& GetTabReferrerUrl() const = 0;
virtual std::string GetSuggestedFilename() const = 0;

Powered by Google App Engine
This is Rietveld 408576698