components/history/core/browser/download_row.cc - Issue 1924473003: [Downloads] Use the initiating StoragePartition for resumption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/download_row.cc

Issue 1924473003: [Downloads] Use the initiating StoragePartition for resumption. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ordering of site_instance_url/SiteInstanceURL fields, and add history test for WebViewTest. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/history/core/browser/download_database.cc ('K') | « components/history/core/browser/download_row.h ('k') | components/history/core/browser/history_backend_db_unittest.cc » ('j') | content/browser/download/download_create_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/download_row.cc

diff --git a/components/history/core/browser/download_row.cc b/components/history/core/browser/download_row.cc

index 04ee62c4940d7a27f13cd53d5100d037f7f74214..5e1821f7e1fbb294574b496919a4a9b94cd36a27 100644

--- a/components/history/core/browser/download_row.cc

+++ b/components/history/core/browser/download_row.cc

@@ -24,6 +24,7 @@ DownloadRow::DownloadRow(const base::FilePath& current_path,

const base::FilePath& target_path,

const std::vector<GURL>& url_chain,

const GURL& referrer_url,

+ const GURL& site_instance_url,

const GURL& tab_url,

const GURL& tab_referrer_url,

const std::string& http_method,

@@ -48,6 +49,7 @@ DownloadRow::DownloadRow(const base::FilePath& current_path,

target_path(target_path),

url_chain(url_chain),

referrer_url(referrer_url),

+ site_instance_url(site_instance_url),

tab_url(tab_url),

tab_referrer_url(tab_referrer_url),

http_method(http_method),

@@ -76,7 +78,8 @@ DownloadRow::~DownloadRow() {}

bool DownloadRow::operator==(const DownloadRow& rhs) const {

return current_path == rhs.current_path && target_path == rhs.target_path &&

url_chain == rhs.url_chain && referrer_url == rhs.referrer_url &&

- tab_url == rhs.tab_url && tab_referrer_url == rhs.tab_referrer_url &&

+ site_instance_url == rhs.site_instance_url && tab_url == rhs.tab_url &&

+ tab_referrer_url == rhs.tab_referrer_url &&

http_method == rhs.http_method && mime_type == rhs.mime_type &&

original_mime_type == rhs.original_mime_type &&

start_time == rhs.start_time && end_time == rhs.end_time &&