chrome/browser/extensions/webstore_installer.cc - Issue 1924473003: [Downloads] Use the initiating StoragePartition for resumption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 1924473003: [Downloads] Use the initiating StoragePartition for resumption. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ordering of site_instance_url/SiteInstanceURL fields, and add history test for WebViewTest. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc » ('j') | components/history/core/browser/download_database.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/webstore_installer.cc

diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc

index e2cddb4a753b8a5f57ec2ca0c51a55345f8eafe4..866c8a4bbbcac3dabc9b5b15c58091901ab1df04 100644

--- a/chrome/browser/extensions/webstore_installer.cc

+++ b/chrome/browser/extensions/webstore_installer.cc

@@ -52,6 +52,7 @@

#include "content/public/browser/render_frame_host.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/render_view_host.h"

+#include "content/public/browser/storage_partition.h"

#include "content/public/browser/web_contents.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

@@ -665,11 +666,15 @@ void WebstoreInstaller::StartDownload(const std::string& extension_id,

int render_process_host_id = contents->GetRenderProcessHost()->GetID();

int render_view_host_routing_id =

contents->GetRenderViewHost()->GetRoutingID();

- content::ResourceContext* resource_context =

- controller.GetBrowserContext()->GetResourceContext();

+ content::RenderFrameHost* render_frame_host = contents->GetMainFrame();

+ content::StoragePartition* storage_partition =

+ BrowserContext::GetStoragePartition(profile_,

+ render_frame_host->GetSiteInstance());

std::unique_ptr<DownloadUrlParameters> params(new DownloadUrlParameters(

download_url_, render_process_host_id, render_view_host_routing_id,

- contents->GetMainFrame()->GetRoutingID(), resource_context));

+ contents->GetMainFrame()->GetRoutingID(),

Charlie Reis 2016/05/05 21:43:22 nit: Can use |render_frame_host| here.

asanka 2016/05/07 00:24:45 Done.

+ storage_partition->GetURLRequestContext()));

params->set_file_path(file);

if (controller.GetVisibleEntry())

params->set_referrer(content::Referrer::SanitizeForRequest(