chrome/browser/download/download_ui_controller_unittest.cc - Issue 1924473003: [Downloads] Use the initiating StoragePartition for resumption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_ui_controller_unittest.cc

Issue 1924473003: [Downloads] Use the initiating StoragePartition for resumption. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_history_unittest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | content/browser/download/download_create_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_ui_controller_unittest.cc

diff --git a/chrome/browser/download/download_ui_controller_unittest.cc b/chrome/browser/download/download_ui_controller_unittest.cc

index 51e9c0a1afdd3ba053ae7b7764ae675d73716e8b..f6ec0bcdac627ff96c75568bcd4921630deaebd5 100644

--- a/chrome/browser/download/download_ui_controller_unittest.cc

+++ b/chrome/browser/download/download_ui_controller_unittest.cc

@@ -218,13 +218,15 @@ DownloadUIControllerTest::CreateMockInProgressDownload() {

EXPECT_CALL(*item, GetState())

.WillRepeatedly(Return(content::DownloadItem::IN_PROGRESS));

EXPECT_CALL(*item, GetUrlChain())

- .WillRepeatedly(testing::ReturnRefOfCopy(std::vector<GURL>()));

+ .WillRepeatedly(ReturnRefOfCopy(std::vector<GURL>()));

EXPECT_CALL(*item, GetReferrerUrl())

- .WillRepeatedly(testing::ReturnRefOfCopy(GURL()));

+ .WillRepeatedly(ReturnRefOfCopy(GURL()));

EXPECT_CALL(*item, GetTabUrl())

- .WillRepeatedly(testing::ReturnRefOfCopy(GURL()));

+ .WillRepeatedly(ReturnRefOfCopy(GURL()));

EXPECT_CALL(*item, GetTabReferrerUrl())

- .WillRepeatedly(testing::ReturnRefOfCopy(GURL()));

+ .WillRepeatedly(ReturnRefOfCopy(GURL()));

+ EXPECT_CALL(*item, GetSiteInstanceUrl())

svaldez 2016/05/05 14:23:27 nit: Same order as elsewhere (Referrer->SiteInstan

asanka 2016/05/05 17:38:05 Done.

+ .WillRepeatedly(ReturnRefOfCopy(GURL()));

EXPECT_CALL(*item, GetStartTime()).WillRepeatedly(Return(base::Time()));

EXPECT_CALL(*item, GetEndTime()).WillRepeatedly(Return(base::Time()));

EXPECT_CALL(*item, GetETag()).WillRepeatedly(ReturnRefOfCopy(std::string()));

@@ -240,7 +242,7 @@ DownloadUIControllerTest::CreateMockInProgressDownload() {

Return(content::DownloadItem::TARGET_DISPOSITION_OVERWRITE));

EXPECT_CALL(*item, GetOpened()).WillRepeatedly(Return(false));

EXPECT_CALL(*item, GetMimeType()).WillRepeatedly(Return(std::string()));

- EXPECT_CALL(*item, GetURL()).WillRepeatedly(testing::ReturnRefOfCopy(GURL()));

+ EXPECT_CALL(*item, GetURL()).WillRepeatedly(ReturnRefOfCopy(GURL()));

EXPECT_CALL(*item, GetWebContents()).WillRepeatedly(Return(nullptr));

EXPECT_CALL(*item, IsTemporary()).WillRepeatedly(Return(false));

return item;