Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: content/browser/download/download_manager_impl_unittest.cc

Issue 1924473003: [Downloads] Use the initiating StoragePartition for resumption. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo in comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_manager_impl_unittest.cc
diff --git a/content/browser/download/download_manager_impl_unittest.cc b/content/browser/download/download_manager_impl_unittest.cc
index 477bcfd37db0860544e3b2014406d3e8aa08733f..e17656e50a725b70abf6277c746ca8f1330d5dd1 100644
--- a/content/browser/download/download_manager_impl_unittest.cc
+++ b/content/browser/download/download_manager_impl_unittest.cc
@@ -87,6 +87,7 @@ class MockDownloadItemImpl : public DownloadItemImpl {
GURL(),
GURL(),
GURL(),
+ GURL(),
"application/octet-stream",
"application/octet-stream",
base::Time(),
@@ -251,6 +252,7 @@ class MockDownloadItemFactory
const base::FilePath& target_path,
const std::vector<GURL>& url_chain,
const GURL& referrer_url,
+ const GURL& site_url,
const GURL& tab_url,
const GURL& tab_referrer_url,
const std::string& mime_type,
@@ -322,6 +324,7 @@ DownloadItemImpl* MockDownloadItemFactory::CreatePersistedItem(
const base::FilePath& target_path,
const std::vector<GURL>& url_chain,
const GURL& referrer_url,
+ const GURL& site_url,
const GURL& tab_url,
const GURL& tab_referrer_url,
const std::string& mime_type,
@@ -751,27 +754,13 @@ TEST_F(DownloadManagerTest, GetDownloadByGuid) {
const char kGuid[] = "8DF158E8-C980-4618-BB03-EBA3242EB48B";
DownloadItem* persisted_item = download_manager_->CreateDownloadItem(
- kGuid,
- 10,
- base::FilePath(),
- base::FilePath(),
- std::vector<GURL>(),
- GURL("http://example.com/a"),
- GURL("http://example.com/a"),
- GURL("http://example.com/a"),
- "application/octet-stream",
- "application/octet-stream",
- base::Time::Now(),
- base::Time::Now(),
- std::string(),
- std::string(),
- 10,
- 10,
- std::string(),
- DownloadItem::INTERRUPTED,
- DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
- DOWNLOAD_INTERRUPT_REASON_SERVER_FAILED,
- false);
+ kGuid, 10, base::FilePath(), base::FilePath(), std::vector<GURL>(),
+ GURL("http://example.com/a"), GURL("http://example.com/a"),
+ GURL("http://example.com/a"), GURL("http://example.com/a"),
+ "application/octet-stream", "application/octet-stream", base::Time::Now(),
+ base::Time::Now(), std::string(), std::string(), 10, 10, std::string(),
+ DownloadItem::INTERRUPTED, DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
+ DOWNLOAD_INTERRUPT_REASON_SERVER_FAILED, false);
ASSERT_TRUE(persisted_item);
ASSERT_EQ(persisted_item, download_manager_->GetDownloadByGuid(kGuid));
« no previous file with comments | « content/browser/download/download_manager_impl.cc ('k') | content/browser/download/download_request_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698