chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc - Issue 1924473003: [Downloads] Use the initiating StoragePartition for resumption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

Issue 1924473003: [Downloads] Use the initiating StoragePartition for resumption. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo in comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/test/data/extensions/platform_apps/web_view/download_cookie_isolation/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

index c3a6f73472ba56ba1d3a5c85611ed53aafa35f32..61eddc61f55d9d04efcddebd713d76f94c7863b3 100644

--- a/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

@@ -273,7 +273,8 @@ class LastDownloadFinderTest : public testing::Test {

return history::DownloadRow(

base::FilePath(file_path), base::FilePath(file_path),

std::vector<GURL>(1, GURL("http://www.google.com")), // url_chain

- GURL("http://referrer.example.com/"), // referrer

+ GURL("http://referrer.example.com/"), // referrer

+ GURL("http://site-url.example.com/"), // site instance URL

GURL("http://tab-url.example.com/"), // tab URL

GURL("http://tab-referrer.example.com/"), // tab referrer URL

std::string(), // HTTP method

@@ -292,9 +293,9 @@ class LastDownloadFinderTest : public testing::Test {

std::string(), // hash

download_id_++, // id

base::GenerateGUID(), // GUID

- false, // download_opened

- std::string(), // ext_id

- std::string()); // ext_name

+ false, // download_opened

+ std::string(), // ext_id

+ std::string()); // ext_name

}

content::TestBrowserThreadBundle browser_thread_bundle_;