Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Unified Diff: chrome/browser/download/download_ui_controller_unittest.cc

Issue 1924473003: [Downloads] Use the initiating StoragePartition for resumption. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo in comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_ui_controller_unittest.cc
diff --git a/chrome/browser/download/download_ui_controller_unittest.cc b/chrome/browser/download/download_ui_controller_unittest.cc
index 51e9c0a1afdd3ba053ae7b7764ae675d73716e8b..d6f9a5cc730d2b5e0cadc060eb3f737b0650a528 100644
--- a/chrome/browser/download/download_ui_controller_unittest.cc
+++ b/chrome/browser/download/download_ui_controller_unittest.cc
@@ -218,13 +218,12 @@ DownloadUIControllerTest::CreateMockInProgressDownload() {
EXPECT_CALL(*item, GetState())
.WillRepeatedly(Return(content::DownloadItem::IN_PROGRESS));
EXPECT_CALL(*item, GetUrlChain())
- .WillRepeatedly(testing::ReturnRefOfCopy(std::vector<GURL>()));
- EXPECT_CALL(*item, GetReferrerUrl())
- .WillRepeatedly(testing::ReturnRefOfCopy(GURL()));
- EXPECT_CALL(*item, GetTabUrl())
- .WillRepeatedly(testing::ReturnRefOfCopy(GURL()));
+ .WillRepeatedly(ReturnRefOfCopy(std::vector<GURL>()));
+ EXPECT_CALL(*item, GetReferrerUrl()).WillRepeatedly(ReturnRefOfCopy(GURL()));
+ EXPECT_CALL(*item, GetSiteUrl()).WillRepeatedly(ReturnRefOfCopy(GURL()));
+ EXPECT_CALL(*item, GetTabUrl()).WillRepeatedly(ReturnRefOfCopy(GURL()));
EXPECT_CALL(*item, GetTabReferrerUrl())
- .WillRepeatedly(testing::ReturnRefOfCopy(GURL()));
+ .WillRepeatedly(ReturnRefOfCopy(GURL()));
EXPECT_CALL(*item, GetStartTime()).WillRepeatedly(Return(base::Time()));
EXPECT_CALL(*item, GetEndTime()).WillRepeatedly(Return(base::Time()));
EXPECT_CALL(*item, GetETag()).WillRepeatedly(ReturnRefOfCopy(std::string()));
@@ -240,7 +239,7 @@ DownloadUIControllerTest::CreateMockInProgressDownload() {
Return(content::DownloadItem::TARGET_DISPOSITION_OVERWRITE));
EXPECT_CALL(*item, GetOpened()).WillRepeatedly(Return(false));
EXPECT_CALL(*item, GetMimeType()).WillRepeatedly(Return(std::string()));
- EXPECT_CALL(*item, GetURL()).WillRepeatedly(testing::ReturnRefOfCopy(GURL()));
+ EXPECT_CALL(*item, GetURL()).WillRepeatedly(ReturnRefOfCopy(GURL()));
EXPECT_CALL(*item, GetWebContents()).WillRepeatedly(Return(nullptr));
EXPECT_CALL(*item, IsTemporary()).WillRepeatedly(Return(false));
return item;
« no previous file with comments | « chrome/browser/download/download_history_unittest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698