[Downloads] Use the initiating StoragePartition for resumption.

content/public/browser/download_url_parameters.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/download_url_parameters.h"
 
 #include "base/callback.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/download_save_info.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
+#include "content/public/browser/storage_partition.h"
 #include "content/public/browser/web_contents.h"
 #include "url/gurl.h"
 
 namespace content {
 
 DownloadUrlParameters::DownloadUrlParameters(
     const GURL& url,
     int render_process_host_id,
     int render_view_host_routing_id,
     int render_frame_host_routing_id,
-    ResourceContext* resource_context)
+    net::URLRequestContextGetter* url_request_context_getter)
     : content_initiated_(false),
       method_("GET"),
       post_id_(-1),
       prefer_cache_(false),
       render_process_host_id_(render_process_host_id),
       render_view_host_routing_id_(render_view_host_routing_id),
       render_frame_host_routing_id_(render_frame_host_routing_id),
-      resource_context_(resource_context),
+      url_request_context_getter_(url_request_context_getter),
       url_(url),
-      do_not_prompt_for_login_(false) {
-}
+      do_not_prompt_for_login_(false) {}
 
 DownloadUrlParameters::~DownloadUrlParameters() {
 }
 
 // static
 std::unique_ptr<DownloadUrlParameters> DownloadUrlParameters::FromWebContents(

[Charlie Reis, 2016/05/05 21:43:23]

I'm a bit concerned about this method, which assumes the download is in the main
frame.  It's called from places like WebContentsImpl::SaveFrameWithHeaders and
RenderViewContextMenu::ExecuteCommand-- are we sure those aren't called when you
interact with a <webview> on a page like chrome://signin?

Maybe this is ok for now, with a bug/TODO to move it to be frame specific if
necessary?  (I'm not sure how it's used, so maybe it's safe.)

[asanka, 2016/05/07 00:24:45]

I think this should be fixed,  but I think that should be a separate change.

For the moment, <webview>s are guest WebContents, correct? Hence talking to the
WebContents should be fine. There are problems with how we deal with context
menus when OOPIF are involved, but that's something that'll need to be dealt
with separately for this change.

[Charlie Reis, 2016/05/10 22:50:02]

Ok.  I wasn't sure how context menus worked for <webview>s, so hopefully it's
not an issue.

(Tangent: I'd be curious to know what issues you're referrng to with context
menus and OOPIFs.  Maybe you can file a bug and CC me if there's a known issue?)

[asanka, 2016/05/11 03:14:52]

I was referring partly to https://codereview.chromium.org/1836973003/#msg11

     WebContents* web_contents,
     const GURL& url) {
+  RenderFrameHost* render_frame_host = web_contents->GetMainFrame();
+  StoragePartition* storage_partition = BrowserContext::GetStoragePartition(
+      web_contents->GetBrowserContext(), render_frame_host->GetSiteInstance());
   return std::unique_ptr<DownloadUrlParameters>(new DownloadUrlParameters(
-      url, web_contents->GetRenderProcessHost()->GetID(),
+      url, render_frame_host->GetProcess()->GetID(),
       web_contents->GetRenderViewHost()->GetRoutingID(),
-      web_contents->GetMainFrame()->GetRoutingID(),
-      web_contents->GetBrowserContext()->GetResourceContext()));
+      render_frame_host->GetRoutingID(),
+      storage_partition->GetURLRequestContext()));
 }
 
 }  // namespace content