[Downloads] Use the initiating StoragePartition for resumption.

content/public/browser/download_url_parameters.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_DOWNLOAD_URL_PARAMETERS_H_
 #define CONTENT_PUBLIC_BROWSER_DOWNLOAD_URL_PARAMETERS_H_
 
 #include <stdint.h>
 
 #include <memory>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/macros.h"
+#include "base/memory/ref_counted.h"
 #include "content/public/browser/download_interrupt_reasons.h"
 #include "content/public/browser/download_save_info.h"
 #include "content/public/common/referrer.h"
+#include "net/url_request/url_request_context_getter.h"
 #include "storage/browser/blob/blob_data_handle.h"
 #include "url/gurl.h"
 
 namespace content {
 
 class DownloadItem;
-class ResourceContext;
 class ResourceDispatcherHost;
 class WebContents;
 
 // Pass an instance of DownloadUrlParameters to DownloadManager::DownloadUrl()
 // to download the content at |url|. All parameters with setters are optional.
 // |referrer| and |referrer_encoding| are the referrer for the download. If
 // |prefer_cache| is true, then if the response to |url| is in the HTTP cache it
 // will be used without revalidation. If |post_id| is non-negative, then it
 // identifies the post transaction used to originally retrieve the |url|
 // resource - it also requires |prefer_cache| to be |true| since re-post'ing is
@@ skipping 17 matching lines @@
   // download request. I.e. the download triggered a warning of some sort and
   // the user chose to not to proceed with the download as a result.
   typedef base::Callback<void(DownloadItem*, DownloadInterruptReason)>
       OnStartedCallback;
 
   typedef std::pair<std::string, std::string> RequestHeadersNameValuePair;
   typedef std::vector<RequestHeadersNameValuePair> RequestHeadersType;
 
   // Construct DownloadUrlParameters for downloading the resource at |url| and
   // associating the download with |web_contents|.
+  //
+  // DEPRECATED: Using this method can cause the request to be associated with
+  // the wrong site instance where multiple iframes are involved. Use the
+  // DownloadUrlParameters constructor below and specify the process and frame
+  // IDs explicitly.
   static std::unique_ptr<DownloadUrlParameters> FromWebContents(
       WebContents* web_contents,
       const GURL& url);
 
   // Construct DownloadUrlParameters for downloading the resource at |url| and
   // associating the download with the WebContents identified by
   // |render_process_host_id| and |render_view_host_routing_id|.
   //
   // If the download is not associated with a WebContents, then set the IDs to
   // -1.
-  // NOTE: This is not safe and should only be done in a limited set of cases
-  // where the download URL has been previously vetted. A download that's
-  // initiated without associating it with a WebContents don't receive the same
-  // security checks as a request that's associated with one. Hence, downloads
-  // that are not associated with a WebContents should only be made for URLs
-  // that are either trusted or URLs that have previously been successfully
-  // issued using a non-privileged WebContents.
-  DownloadUrlParameters(const GURL& url,
-                        int render_process_host_id,
-                        int render_view_host_routing_id,
-                        int render_frame_host_routing_id,
-                        ResourceContext* resource_context);
+  //
+  // NOTE: Initiating downloads that are not associated with a WebContents is
+  // not safe and should only be done in a limited set of cases where the
+  // download URL has been previously vetted. A download that's initiated
+  // without associating it with a WebContents don't receive the same security
+  // checks as a request that's associated with one. Hence, downloads that are
+  // not associated with a WebContents should only be made for URLs that are
+  // either trusted or URLs that have previously been successfully issued using
+  // a non-privileged WebContents.
+  DownloadUrlParameters(
+      const GURL& url,
+      int render_process_host_id,
+      int render_view_host_routing_id,
+      int render_frame_host_routing_id,
+      net::URLRequestContextGetter* url_request_context_getter);
 
   ~DownloadUrlParameters();
 
   // Should be set to true if the download was initiated by a script or a web
   // page. I.e. if the download request cannot be attributed to an explicit user
   // request for a download, then set this value to true.
   void set_content_initiated(bool content_initiated) {
     content_initiated_ = content_initiated;
   }
   void add_request_header(const std::string& name, const std::string& value) {
@@ skipping 110 matching lines @@
   const Referrer& referrer() const { return referrer_; }
   const std::string& referrer_encoding() const { return referrer_encoding_; }
   int render_process_host_id() const { return render_process_host_id_; }
   int render_view_host_routing_id() const {
     return render_view_host_routing_id_;
   }
   int render_frame_host_routing_id() const {
     return render_frame_host_routing_id_;
   }
   const RequestHeadersType& request_headers() const { return request_headers_; }
-  ResourceContext* resource_context() const { return resource_context_; }
+  net::URLRequestContextGetter* url_request_context_getter() {
+    return url_request_context_getter_.get();
+  }
   const base::FilePath& file_path() const { return save_info_.file_path; }
   const base::string16& suggested_name() const {
     return save_info_.suggested_name;
   }
   int64_t offset() const { return save_info_.offset; }
   const std::string& hash_of_partial_file() const {
     return save_info_.hash_of_partial_file;
   }
   bool prompt() const { return save_info_.prompt_for_save_location; }
   const GURL& url() const { return url_; }
@@ skipping 16 matching lines @@
   std::string etag_;
   std::string method_;
   std::string post_body_;
   int64_t post_id_;
   bool prefer_cache_;
   Referrer referrer_;
   std::string referrer_encoding_;
   int render_process_host_id_;
   int render_view_host_routing_id_;
   int render_frame_host_routing_id_;
-  ResourceContext* resource_context_;
+  scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
   DownloadSaveInfo save_info_;
   GURL url_;
   bool do_not_prompt_for_login_;
   std::unique_ptr<storage::BlobDataHandle> blob_data_handle_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadUrlParameters);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DOWNLOAD_URL_PARAMETERS_H_