[Downloads] Use the initiating StoragePartition for resumption.

components/history/core/browser/history_backend_db_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // History unit tests come in two flavors:
 //
 // 1. The more complicated style is that the unit test creates a full history
 //    service. This spawns a background thread for the history backend, and
 //    all communication is asynchronous. This is useful for testing more
 //    complicated things or end-to-end behavior.
@@ skipping 619 matching lines @@
           "VALUES("
           "    1, '435A5C7A-F6B7-4DF2-8696-22E4FCBA3EB2', 'foo.txt', 'foo.txt',"
           "    13104873187307670, 11, 11, 1, 0, 0, X'', 13104873187521021, 0,"
           "    'http://example.com/dl/', '', '', '', '', '', 'text/plain',"
           "    'text/plain')"));
       ASSERT_TRUE(s.Run());
     }
     {
       sql::Statement s(db.GetUniqueStatement(
           "INSERT INTO downloads_url_chains (id, chain_index, url) VALUES "
-          "(4, 0, 'url')"));
+          "(1, 0, 'url')"));
       ASSERT_TRUE(s.Run());
     }
   }
 
   // Re-open the db using the HistoryDatabase, which should migrate to the
   // current version, creating the tab_url and tab_referrer_url columns.
   CreateBackendAndDatabase();
   DeleteBackend();
   {
     // Re-open the db for manual manipulation.
@@ skipping 11 matching lines @@
     {
       sql::Statement s(db.GetUniqueStatement(
           "SELECT tab_url, tab_referrer_url from downloads"));
       EXPECT_TRUE(s.Step());
       EXPECT_EQ(std::string(), s.ColumnString(0));
       EXPECT_EQ(std::string(), s.ColumnString(1));
     }
   }
 }
 
+TEST_F(HistoryBackendDBTest, MigrateDownloadSiteInstanceUrl) {
+  ASSERT_NO_FATAL_FAILURE(CreateDBVersion(31));
+  {
+    sql::Connection db;
+    ASSERT_TRUE(db.Open(history_dir_.Append(kHistoryFilename)));
+    {
+      sql::Statement s(db.GetUniqueStatement(
+          "INSERT INTO downloads ("
+          "    id, guid, current_path, target_path, start_time, received_bytes,"
+          "    total_bytes, state, danger_type, interrupt_reason, hash,"
+          "    end_time, opened, referrer, tab_url, tab_referrer_url,"
+          "    http_method, by_ext_id, by_ext_name, etag, last_modified,"
+          "    mime_type, original_mime_type)"
+          "VALUES("
+          "    1, '435A5C7A-F6B7-4DF2-8696-22E4FCBA3EB2', 'foo.txt', 'foo.txt',"
+          "    13104873187307670, 11, 11, 1, 0, 0, X'', 13104873187521021, 0,"
+          "    'http://example.com/dl/', '', '', '', '', '', '', '',"
+          "    'text/plain', 'text/plain')"));
+      ASSERT_TRUE(s.Run());
+    }
+    {
+      sql::Statement s(db.GetUniqueStatement(
+          "INSERT INTO downloads_url_chains (id, chain_index, url) VALUES "
+          "(1, 0, 'url')"));
+      ASSERT_TRUE(s.Run());
+    }
+  }
+
+  // Re-open the db using the HistoryDatabase, which should migrate to the
+  // current version, creating the site_url column.
+  CreateBackendAndDatabase();
+  DeleteBackend();
+  {
+    // Re-open the db for manual manipulation.
+    sql::Connection db;
+    ASSERT_TRUE(db.Open(history_dir_.Append(kHistoryFilename)));
+    // The version should have been updated.
+    int cur_version = HistoryDatabase::GetCurrentVersion();
+    ASSERT_LE(31, cur_version);
+    {
+      sql::Statement s(db.GetUniqueStatement(
+          "SELECT value FROM meta WHERE key = 'version'"));
+      EXPECT_TRUE(s.Step());
+      EXPECT_EQ(cur_version, s.ColumnInt(0));
+    }
+    {
+      sql::Statement s(db.GetUniqueStatement("SELECT site_url from downloads"));
+      EXPECT_TRUE(s.Step());
+      EXPECT_EQ(std::string(), s.ColumnString(0));
+    }
+  }
+}
+
 TEST_F(HistoryBackendDBTest, DownloadCreateAndQuery) {
   CreateBackendAndDatabase();
 
   ASSERT_EQ(0u, db_->CountDownloads());
 
   std::vector<GURL> url_chain;
   url_chain.push_back(GURL("http://example.com/a"));
   url_chain.push_back(GURL("http://example.com/b"));
   url_chain.push_back(GURL("http://example.com/c"));
 
   base::Time start_time(base::Time::Now());
   base::Time end_time(start_time + base::TimeDelta::FromHours(1));
 
   DownloadRow download_A(
       base::FilePath(FILE_PATH_LITERAL("/path/1")),
       base::FilePath(FILE_PATH_LITERAL("/path/2")), url_chain,
-      GURL("http://example.com/referrer"), GURL("http://example.com/tab-url"),
+      GURL("http://example.com/referrer"), GURL("http://example.com"),
+      GURL("http://example.com/tab-url"),
       GURL("http://example.com/tab-referrer"), "GET", "mime/type",
       "original/mime-type", start_time, end_time, "etag1", "last_modified_1",
       100, 1000, DownloadState::INTERRUPTED, DownloadDangerType::NOT_DANGEROUS,
       kTestDownloadInterruptReasonCrash, "hash-value1", 1,
       "FE672168-26EF-4275-A149-FEC25F6A75F9", false, "extension-id",
       "extension-name");
   ASSERT_TRUE(db_->CreateDownload(download_A));
 
   url_chain.push_back(GURL("http://example.com/d"));
 
   base::Time start_time2(start_time + base::TimeDelta::FromHours(10));
   base::Time end_time2(end_time + base::TimeDelta::FromHours(10));
 
   DownloadRow download_B(
       base::FilePath(FILE_PATH_LITERAL("/path/3")),
       base::FilePath(FILE_PATH_LITERAL("/path/4")), url_chain,
-      GURL("http://example.com/referrer2"), GURL("http://example.com/tab-url2"),
+      GURL("http://example.com/referrer2"), GURL("http://2.example.com"),
+      GURL("http://example.com/tab-url2"),
       GURL("http://example.com/tab-referrer2"), "POST", "mime/type2",
       "original/mime-type2", start_time2, end_time2, "etag2", "last_modified_2",
       1001, 1001, DownloadState::COMPLETE, DownloadDangerType::DANGEROUS_FILE,
       kTestDownloadInterruptReasonNone, std::string(), 2,
       "b70f3869-7d75-4878-acb4-4caf7026d12b", false, "extension-id",
       "extension-name");
   ASSERT_TRUE(db_->CreateDownload(download_B));
 
   EXPECT_EQ(2u, db_->CountDownloads());
 
@@ skipping 18 matching lines @@
   url_chain.push_back(GURL("http://example.com/a"));
   url_chain.push_back(GURL("http://example.com/b"));
   url_chain.push_back(GURL("http://example.com/c"));
 
   base::Time start_time(base::Time::Now());
   base::Time end_time(start_time + base::TimeDelta::FromHours(1));
 
   DownloadRow download(
       base::FilePath(FILE_PATH_LITERAL("/path/1")),
       base::FilePath(FILE_PATH_LITERAL("/path/2")), url_chain,
-      GURL("http://example.com/referrer"), GURL("http://example.com/tab-url"),
+      GURL("http://example.com/referrer"), GURL("http://example.com"),
+      GURL("http://example.com/tab-url"),
       GURL("http://example.com/tab-referrer"), "GET", "mime/type",
       "original/mime-type", start_time, end_time, "etag1", "last_modified_1",
       100, 1000, DownloadState::INTERRUPTED, DownloadDangerType::NOT_DANGEROUS,
       3, "some-hash-value", 1, "FE672168-26EF-4275-A149-FEC25F6A75F9", false,
       "extension-id", "extension-name");
   db_->CreateDownload(download);
 
   download.current_path =
       base::FilePath(FILE_PATH_LITERAL("/new/current_path"));
   download.target_path = base::FilePath(FILE_PATH_LITERAL("/new/target_path"));
@@ skipping 78 matching lines @@
 }
 
 TEST_F(HistoryBackendDBTest, DownloadNukeRecordsMissingURLs) {
   CreateBackendAndDatabase();
   base::Time now(base::Time::Now());
   std::vector<GURL> url_chain;
   DownloadRow download(
       base::FilePath(FILE_PATH_LITERAL("foo-path")),
       base::FilePath(FILE_PATH_LITERAL("foo-path")), url_chain,
       GURL(std::string()), GURL(std::string()), GURL(std::string()),
-      std::string(), "application/octet-stream", "application/octet-stream",
-      now, now, std::string(), std::string(), 0, 512, DownloadState::COMPLETE,
-      DownloadDangerType::NOT_DANGEROUS, kTestDownloadInterruptReasonNone,
-      std::string(), 1, "05AF6C8E-E4E0-45D7-B5CE-BC99F7019918", 0, "by_ext_id",
-      "by_ext_name");
+      GURL(std::string()), std::string(), "application/octet-stream",
+      "application/octet-stream", now, now, std::string(), std::string(), 0,
+      512, DownloadState::COMPLETE, DownloadDangerType::NOT_DANGEROUS,
+      kTestDownloadInterruptReasonNone, std::string(), 1,
+      "05AF6C8E-E4E0-45D7-B5CE-BC99F7019918", 0, "by_ext_id", "by_ext_name");
 
   // Creating records without any urls should fail.
   EXPECT_FALSE(db_->CreateDownload(download));
 
   download.url_chain.push_back(GURL("foo-url"));
   EXPECT_TRUE(db_->CreateDownload(download));
 
   // Pretend that the URLs were dropped.
   DeleteBackend();
   {
@@ skipping 230 matching lines @@
   // URL should win instead.
   std::vector<std::unique_ptr<PageUsageData>> results2 =
       db_->QuerySegmentUsage(time, 1, base::Bind(&FilterURL));
   ASSERT_EQ(1u, results2.size());
   EXPECT_EQ(url2, results2[0]->GetURL());
   EXPECT_EQ(segment_id2, results2[0]->GetID());
 }
 
 }  // namespace
 }  // namespace history