chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java - Issue 1924473002: Don't hide the reparenting tab while detaching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java

Issue 1924473002: Don't hide the reparenting tab while detaching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java

index cf5d9e898429677c1d9d89d029f8561ed258597b..0af3ce9f25d8a3c5dfc3aaa4adfaf0b65d670750 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java

@@ -342,7 +342,7 @@ public class TabModelSelectorImpl extends TabModelSelectorBase implements TabMod

TabModelImpl.startTabSwitchLatencyTiming(type);

}

if (mVisibleTab != null && mVisibleTab != tab && !mVisibleTab.needsReload()) {

- if (mVisibleTab.isInitialized()) {

+ if (mVisibleTab.isInitialized() && !mVisibleTab.isDetachedForReparenting()) {

// TODO(dtrainor): Once we figure out why we can't grab a snapshot from the current

// tab when we have other tabs loading from external apps remove the checks for

// FROM_EXTERNAL_APP/FROM_NEW.