Don't hide the reparenting tab while detaching

chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.tab;
 
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
 import android.content.res.Resources;
@@ skipping 334 matching lines @@
 
     private TabRedirectHandler mTabRedirectHandler;
 
     private FullscreenManager mFullscreenManager;
     private float mPreviousFullscreenTopControlsOffsetY = Float.NaN;
     private float mPreviousFullscreenContentOffsetY = Float.NaN;
     private int mFullscreenHungRendererToken = FullscreenManager.INVALID_TOKEN;
     private boolean mIsFullscreenWaitingForLoad = false;
 
     /**
+     * Indicates whether this tab has been detached from its activity and the corresponding
+     * {@link WindowAndroid} for reparenting to a new activity.
+     */
+    private boolean mDetachedForReparenting;
+
+    /**
      * The UMA object used to report stats for this tab. Note that this may be null under certain
      * conditions, such as incognito mode.
      */
     private TabUma mTabUma;
 
     /**
      * Reference to the current sadTabView if one is defined.
      */
     private View mSadTabView;
 
@@ skipping 1047 matching lines @@
      *               launching the new host activity. This intent's URI and action will be
      *               overriden. This may be null if no intent customization is needed.
      * @param startActivityOptions Options to pass to {@link Activity#startActivity(Intent, Bundle)}
      * @param finalizeCallback A callback that will be called after the tab is attached to the new
      *                         host activity in {@link #attachAndFinishReparenting}.
      * @return Whether reparenting succeeded. If false, the tab was not removed and the intent was
      *         not fired.
      */
     public boolean detachAndStartReparenting(Intent intent, Bundle startActivityOptions,
             Runnable finalizeCallback) {
+        mDetachedForReparenting = true;
         ChromeActivity activity = getActivity();
         if (activity == null) return false;
         TabModelSelector tabModelSelector = getTabModelSelector();
         if (tabModelSelector == null) return false;
         tabModelSelector.getModel(mIncognito).removeTab(this);
 
         if (mContentViewCore != null) mContentViewCore.updateWindowAndroid(null);
         attachTabContentManager(null);
 
         if (intent == null) intent = new Intent();
@@ skipping 43 matching lines @@
                 mWebContentsDelegate, mDelegateFactory.createContextMenuPopulator(this));
         mTopControlsVisibilityDelegate = mDelegateFactory.createTopControlsVisibilityDelegate(this);
         setInterceptNavigationDelegate(mDelegateFactory.createInterceptNavigationDelegate(this));
         mAppBannerManager = mDelegateFactory.createAppBannerManager(this);
 
         // Reload the NativePage (if any), since the old NativePage has a reference to the old
         // activity.
         maybeShowNativePage(getUrl(), true);
 
         reparentingParams.finalizeTabReparenting();
+        mDetachedForReparenting = false;

[gone, 2016/04/26 22:05:38]

nit: mIsDetachedForReparenting

[Yusuf, 2016/04/26 22:10:15]

Done.

     }
 
     /**
+     * @return Whether the tab is detached from its Activity and {@link WindowAndroid} for
+     * reparenting. Certain functionalities will not work until it is attached to a new activity
+     * with {@link Tab#attachAndFinishReparenting(
+     * ChromeActivity, TabDelegateFactory, TabReparentingParams)}.
+     */
+    public boolean isDetachedForReparenting() {
+        return mDetachedForReparenting;
+    }
+
+    /**
      * Attach the content layer for this tab to the given {@link TabContentManager}.
      * @param tabContentManager {@link TabContentManager} to attach to.
      */
     public void attachTabContentManager(TabContentManager tabContentManager) {
         nativeAttachToTabContentManager(mNativeTabAndroid, tabContentManager);
     }
 
     /**
      * @return The delegate factory for testing purposes only.
      */
@@ skipping 1669 matching lines @@
     private native void nativeSetInterceptNavigationDelegate(long nativeTabAndroid,
             InterceptNavigationDelegate delegate);
     private native void nativeAttachToTabContentManager(long nativeTabAndroid,
             TabContentManager tabContentManager);
     private native void nativeAttachOverlayContentViewCore(long nativeTabAndroid,
             ContentViewCore content, boolean visible);
     private native void nativeDetachOverlayContentViewCore(long nativeTabAndroid,
             ContentViewCore content);
     private native boolean nativeHasPrerenderedUrl(long nativeTabAndroid, String url);
 }