Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 1924453002: clovis: Enable the disable-by-default-blink.debug.layout tracing category. (Closed)

Created:
4 years, 8 months ago by Benoit L
Modified:
4 years, 7 months ago
Reviewers:
mattcary
CC:
chromium-reviews, mikecase+watch_chromium.org, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, lizeb+watch-android-loading_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clovis: Enable the disabled-by-default-blink.debug.layout tracing category. This category is used by FirstSignificantPaintLens, as pointed out by mattcary@. Committed: https://crrev.com/188dfe59bb04b695ee7186758a75b9ee8a1afce5 Cr-Commit-Position: refs/heads/master@{#390041}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : Address comments. #

Patch Set 4 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -15 lines) Patch
M tools/android/loading/tracing.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/android/loading/user_satisfied_lens.py View 1 2 3 4 chunks +18 lines, -9 lines 0 comments Download
M tools/android/loading/user_satisfied_lens_unittest.py View 1 2 3 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benoit L
4 years, 8 months ago (2016-04-26 17:19:34 UTC) #3
mattcary
lgtm https://codereview.chromium.org/1924453002/diff/20001/tools/android/loading/user_satisfied_lens.py File tools/android/loading/user_satisfied_lens.py (right): https://codereview.chromium.org/1924453002/diff/20001/tools/android/loading/user_satisfied_lens.py#newcode145 tools/android/loading/user_satisfied_lens.py:145: FIRST_LAYOUT_COUNTER = 'LayoutObjectsThatHadNeverHadLayout' While you're in here add ...
4 years, 7 months ago (2016-04-27 08:00:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924453002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924453002/60001
4 years, 7 months ago (2016-04-27 09:28:03 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-27 10:55:02 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 10:56:44 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/188dfe59bb04b695ee7186758a75b9ee8a1afce5
Cr-Commit-Position: refs/heads/master@{#390041}

Powered by Google App Engine
This is Rietveld 408576698