Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: runtime/vm/json_stream.cc

Issue 192443004: Complete the switch to ServiceObject (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/json_stream.cc
diff --git a/runtime/vm/json_stream.cc b/runtime/vm/json_stream.cc
index 9fffcae4aa0818b587202c4e45024bd246f1ae51..b276b842a5d44da82b2b8c4515cfeab73f9dcc39 100644
--- a/runtime/vm/json_stream.cc
+++ b/runtime/vm/json_stream.cc
@@ -80,8 +80,12 @@ void JSONStream::Setup(Zone* zone,
Isolate* isolate = Isolate::Current();
ASSERT(isolate != NULL);
const char* isolate_name = isolate->name();
- OS::Print("Isolate %s processing service request /%s\n",
+ OS::Print("Isolate %s processing service request /%s",
isolate_name, command_);
+ for (intptr_t i = 1; i < num_arguments(); i++) {
+ OS::Print("/%s", GetArgument(i));
+ }
+ OS::Print("\n");
setup_time_micros_ = OS::GetCurrentTimeMicros();
}
}
@@ -114,8 +118,12 @@ void JSONStream::PostReply() {
Isolate* isolate = Isolate::Current();
ASSERT(isolate != NULL);
const char* isolate_name = isolate->name();
- OS::Print("Isolate %s processed service request /%s in %" Pd64" us.\n",
- isolate_name, command_, process_delta_micros);
+ OS::Print("Isolate %s processed service request /%s",
+ isolate_name, command_);
+ for (intptr_t i = 1; i < num_arguments(); i++) {
+ OS::Print("/%s", GetArgument(i));
+ }
+ OS::Print(" in %" Pd64" us.\n", process_delta_micros);
}
}
@@ -197,7 +205,7 @@ void JSONStream::PrintValue(double d) {
void JSONStream::PrintValue(const char* s) {
PrintCommaIfNeeded();
buffer_.AddChar('"');
- buffer_.AddEscapedString(s);
+ buffer_.AddEscapedUTF8String(s);
buffer_.AddChar('"');
}
@@ -215,7 +223,7 @@ void JSONStream::PrintfValue(const char* format, ...) {
va_end(args);
ASSERT(len == len2);
buffer_.AddChar('"');
- buffer_.AddEscapedString(p);
+ buffer_.AddEscapedUTF8String(p);
buffer_.AddChar('"');
free(p);
}
@@ -275,7 +283,7 @@ void JSONStream::PrintfProperty(const char* name, const char* format, ...) {
va_end(args);
ASSERT(len == len2);
buffer_.AddChar('"');
- buffer_.AddEscapedString(p);
+ buffer_.AddEscapedUTF8String(p);
buffer_.AddChar('"');
free(p);
}
@@ -311,7 +319,7 @@ void JSONStream::PrintPropertyName(const char* name) {
ASSERT(name != NULL);
PrintCommaIfNeeded();
buffer_.AddChar('"');
- buffer_.AddEscapedString(name);
+ buffer_.AddEscapedUTF8String(name);
buffer_.AddChar('"');
buffer_.AddChar(':');
}
@@ -353,7 +361,7 @@ void JSONObject::AddPropertyF(const char* name,
va_end(args);
ASSERT(len == len2);
stream_->buffer_.AddChar('"');
- stream_->buffer_.AddEscapedString(p);
+ stream_->buffer_.AddEscapedUTF8String(p);
stream_->buffer_.AddChar('"');
free(p);
}
@@ -371,7 +379,7 @@ void JSONArray::AddValueF(const char* format, ...) const {
va_end(args);
ASSERT(len == len2);
stream_->buffer_.AddChar('"');
- stream_->buffer_.AddEscapedString(p);
+ stream_->buffer_.AddEscapedUTF8String(p);
stream_->buffer_.AddChar('"');
free(p);
}

Powered by Google App Engine
This is Rietveld 408576698