Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/stack_trace.dart

Issue 192443004: Complete the switch to ServiceObject (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/stack_trace.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/stack_trace.dart b/runtime/bin/vmservice/client/lib/src/elements/stack_trace.dart
index 6ccbab25a1e6eb3b279afa0900ebd44907dd5efe..f92630eb2b8b516123da7287fcaa834a4fc28b81 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/stack_trace.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/stack_trace.dart
@@ -4,21 +4,17 @@
library stack_trace_element;
-import 'package:logging/logging.dart';
import 'package:polymer/polymer.dart';
-import 'isolate_element.dart';
+import 'observatory_element.dart';
+import 'package:observatory/service.dart';
@CustomTag('stack-trace')
-class StackTraceElement extends IsolateElement {
- @published Map trace = toObservable({});
+class StackTraceElement extends ObservatoryElement {
+ @published ServiceMap trace;
StackTraceElement.created() : super.created();
void refresh(var done) {
- isolate.getMap('stacktrace').then((map) {
- trace = map;
- }).catchError((e, trace) {
- Logger.root.severe('Error while reloading stack trace: $e\n$trace');
- }).whenComplete(done);
+ trace.reload().whenComplete(done);
}
}

Powered by Google App Engine
This is Rietveld 408576698