runtime/bin/vmservice/client/lib/src/elements/script_view.html - Issue 192443004: Complete the switch to ServiceObject

Side by Side Diff: runtime/bin/vmservice/client/lib/src/elements/script_view.html

Issue 192443004: Complete the switch to ServiceObject (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/script_view.dart ('k') | runtime/bin/vmservice/client/lib/src/elements/service_ref.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <head>	1 <head>

2 <link rel="import" href="nav_bar.html">	2 <link rel="import" href="nav_bar.html">

3 <link rel="import" href="isolate_element.html">	3 <link rel="import" href="observatory_element.html">

4 </head>	4 </head>

5 <polymer-element name="script-view" extends="isolate-element">	5 <polymer-element name="script-view" extends="observatory-element">

6 <template>	6 <template>

7 <nav-bar>	7 <nav-bar>

8 <top-nav-menu></top-nav-menu>	8 <top-nav-menu></top-nav-menu>

9 <isolate-nav-menu isolate="{{ isolate }}">	9 <isolate-nav-menu isolate="{{ script.isolate }}">

10 </isolate-nav-menu>	10 </isolate-nav-menu>

11 <library-nav-menu isolate="{{ isolate }}" library="{{ script.libraryRef }}"> </library-nav-menu>	11 <library-nav-menu library="{{ script.library }}"></library-nav-menu>

12 <nav-menu link="." anchor="{{ script.shortName }}" last="{{ true }}"></nav-m enu>	12 <nav-menu link="." anchor="{{ script.name }}" last="{{ true }}">

	13 <li>

	14 <input type="checkbox" checked="{{ showCoverage }}">

	15 <label>Show Coverage Data</label>

	16 </li>

	17 </nav-menu>

	18 <nav-refresh callback="{{ refreshCoverage }}" label="Refresh Coverage"></nav -refresh>

	19 <nav-refresh callback="{{ refresh }}">

	20 </nav-refresh>

13 </nav-bar>	21 </nav-bar>

14	22

15 <div class="row">	23 <div class="row">

16 <div class="col-md-8 col-md-offset-2">	24 <div class="col-md-8 col-md-offset-2">

17 <div class="panel-heading">	25 <div class="panel-heading">Script source for: {{ script.name }}</div>

18 <button on-click="{{refreshCoverage}}">Refresh Coverage</button>

19 {{ script.scriptRef['user_name'] }}

20 {{ script.coveredPercentageFormatted() }}

21 </div>

22 <div class="panel-body">	26 <div class="panel-body">

23 <table style="width:100%">	27 <table style="width:100%">

24 <tbody>	28 <tbody>

25 <tr template repeat="{{ line in script.linesForDisplay }}">	29 <tr template repeat="{{ line in script.lines }}">

26 <td style="{{ hitsStyle(line) }}"> </td>	30 <td style="{{ hitsStyle(line) }}"> </td>
	turnidge 2014/03/11 16:40:07 Unrelated to this review: you could use classes/st Unrelated to this review: you could use classes/styles here to move the css stuff out of the dart file and into the html file for hitstyle.
27 <td style="font-family: consolas, courier, monospace;font-size: 1em; line-height: 1.2em;white-space: nowrap;">{{line.line}}</td>	31 <td style="font-family: consolas, courier, monospace;font-size: 1em; line-height: 1.2em;white-space: nowrap;">{{line.line}}</td>

28 <td width="99%" style="font-family: consolas, courier, monospace;fon t-size: 1em;line-height: 1.2em;white-space: pre;">{{line.text}}</td>	32 <td width="99%" style="font-family: consolas, courier, monospace;fon t-size: 1em;line-height: 1.2em;white-space: pre;">{{line.text}}</td>

29 </tr>	33 </tr>

30 </tbody>	34 </tbody>

31 </table>	35 </table>

32 </div>	36 </div>

33 </div>	37 </div>

34 </div>	38 </div>

35 </template>	39 </template>

36 <script type="application/dart" src="script_view.dart"></script>	40 <script type="application/dart" src="script_view.dart"></script>

37 </polymer-element>	41 </polymer-element>

OLD	NEW