Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issue 192443003: Define print format macros for NSInteger & NSUInteger (Closed)

Created:
6 years, 9 months ago by sdefresne
Modified:
6 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Define print format macros for NSInteger & NSUInteger The size of NSInteger and NSUInteger varies between 32-bit and 64-bit architectures, however does not provides macro to safely format them and instead recommend casting the value to the larger version that is used on 64-bit architecture. Using a cast could cause some formatting to be missed (if the type of a variable changes), so instead we define our own macros to format those types safely. BUG=349458 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256019

Patch Set 1 #

Patch Set 2 : Fix 64-bit unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
M base/format_macros.h View 1 chunk +28 lines, -0 lines 0 comments Download
M base/mac/foundation_util_unittest.mm View 1 2 chunks +73 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sdefresne
This is a re-land of revision 255755, after fixing and running the 64-bit version of ...
6 years, 9 months ago (2014-03-10 09:57:22 UTC) #1
Mark Mentovai
LGTM
6 years, 9 months ago (2014-03-10 13:56:30 UTC) #2
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 9 months ago (2014-03-10 13:59:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/192443003/20001
6 years, 9 months ago (2014-03-10 14:28:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/192443003/20001
6 years, 9 months ago (2014-03-10 15:52:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/192443003/20001
6 years, 9 months ago (2014-03-10 17:39:33 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 20:16:37 UTC) #7
Message was sent while issue was closed.
Change committed as 256019

Powered by Google App Engine
This is Rietveld 408576698