Fix modulo and bitwise operators.

Fix modulo and bitwise operators.

Dart `%` is modulo, JS `%` is remainder, so call the runtime version.

Use dart2js interpretation of bit operations and shifts which always
produce a 32-bit unsigned result.

Optimization of the bit operations to follow.

BUG= https://github.com/dart-lang/dev_compiler/issues/518
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/8ab6b7172aeaeabc17e229f2366fb73bebf1af6c

[sra1, 2016-04-28 19:51:15]

Description was changed from

==========
Fix modulo and bitwise operators.

Dart `%` is modulo, JS `%` is remainder, so call the runtime version.

Use dart2js interpretation of bit operations and shifts which always
produce a 32-bit unsigned result.

Optimization of the bit operations to follow.
==========

to

==========
Fix modulo and bitwise operators.

Dart `%` is modulo, JS `%` is remainder, so call the runtime version.

Use dart2js interpretation of bit operations and shifts which always
produce a 32-bit unsigned result.

Optimization of the bit operations to follow.

https://github.com/dart-lang/dev_compiler/issues/518
==========

[sra1, 2016-04-28 19:51:15]

sra@google.com changed reviewers:
+ jmesserly@google.com

[sra1, 2016-04-28 19:51:35]

Description was changed from

==========
Fix modulo and bitwise operators.

Dart `%` is modulo, JS `%` is remainder, so call the runtime version.

Use dart2js interpretation of bit operations and shifts which always
produce a 32-bit unsigned result.

Optimization of the bit operations to follow.

https://github.com/dart-lang/dev_compiler/issues/518
==========

to

==========
Fix modulo and bitwise operators.

Dart `%` is modulo, JS `%` is remainder, so call the runtime version.

Use dart2js interpretation of bit operations and shifts which always
produce a 32-bit unsigned result.

Optimization of the bit operations to follow.

BUG= https://github.com/dart-lang/dev_compiler/issues/518
==========

[sra1, 2016-04-28 19:56:37]

https://codereview.chromium.org/1924413002/diff/1/lib/runtime/dart_sdk.js
File lib/runtime/dart_sdk.js (right):

https://codereview.chromium.org/1924413002/diff/1/lib/runtime/dart_sdk.js#new...
lib/runtime/dart_sdk.js:3235: +      hash = (536870911 & hash + ((67108863 &
hash) >>> 0)[dartx['<<']](3)) >>> 0;
Optimizations in following CL can recover the original code for this line.

https://codereview.chromium.org/1924413002/diff/1/test/browser/language_tests.js
File test/browser/language_tests.js (right):

https://codereview.chromium.org/1924413002/diff/1/test/browser/language_tests...
test/browser/language_tests.js:28: 'branch_canonicalization_test',  // JS bit
operations truncate to 32 bits.
This is suppressed in language_dart2js.status

[Jennifer Messerly, 2016-04-28 20:08:52]

LGTM!

https://codereview.chromium.org/1924413002/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1924413002/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:2822: case TokenType.TILDE_SLASH:
this looks great, love the refactoring!

https://codereview.chromium.org/1924413002/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:2861: // Bit operations are coerced to
values on [0, 2^32). The coercion changes
move this to be a doc comment?

[sra1, 2016-04-28 20:47:33]

Description was changed from

==========
Fix modulo and bitwise operators.

Dart `%` is modulo, JS `%` is remainder, so call the runtime version.

Use dart2js interpretation of bit operations and shifts which always
produce a 32-bit unsigned result.

Optimization of the bit operations to follow.

BUG= https://github.com/dart-lang/dev_compiler/issues/518
==========

to

==========
Fix modulo and bitwise operators.

Dart `%` is modulo, JS `%` is remainder, so call the runtime version.

Use dart2js interpretation of bit operations and shifts which always
produce a 32-bit unsigned result.

Optimization of the bit operations to follow.

BUG= https://github.com/dart-lang/dev_compiler/issues/518
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/8ab6b7172aeaeabc17e229f2366f...
==========

[sra1, 2016-04-28 20:47:34]

Committed patchset #2 (id:20001) manually as
8ab6b7172aeaeabc17e229f2366fb73bebf1af6c (presubmit successful).