Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1924403002: Stop using deprecated hash_map in vtune-jit.cc. (Closed)

Created:
4 years, 7 months ago by bnoordhuis
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stop using deprecated hash_map in vtune-jit.cc. Fixes https://github.com/nodejs/node/issues/6422. Committed: https://crrev.com/54c47545eff77d4fcb75959134d37fe2013607d2 Cr-Commit-Position: refs/heads/master@{#35916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -22 lines) Patch
M src/third_party/vtune/vtune-jit.cc View 2 chunks +3 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
noordhuis
4 years, 7 months ago (2016-04-28 19:48:05 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-04-28 19:50:57 UTC) #3
noordhuis
It says "Commit queue not available (can’t edit this change)" and I can't land it. ...
4 years, 7 months ago (2016-04-30 10:39:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924403002/1
4 years, 7 months ago (2016-04-30 11:13:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-30 11:31:06 UTC) #7
Benedikt Meurer
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1940693002/ by bmeurer@chromium.org. ...
4 years, 7 months ago (2016-04-30 18:24:44 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:04:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54c47545eff77d4fcb75959134d37fe2013607d2
Cr-Commit-Position: refs/heads/master@{#35916}

Powered by Google App Engine
This is Rietveld 408576698