Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1924353002: Added a lock check for CommandBufferProxyImpl::OrderingBarrier(). (Closed)

Created:
4 years, 7 months ago by David Yen
Modified:
4 years, 7 months ago
Reviewers:
Antoine Labour, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added a lock check for CommandBufferProxyImpl::OrderingBarrier(). R=piman@chromium.org BUG=606112 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/46893a3125cca64012e98924ecd93756841f2c98 Cr-Commit-Position: refs/heads/master@{#390484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gpu/ipc/client/command_buffer_proxy_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
David Yen
4 years, 7 months ago (2016-04-28 18:25:10 UTC) #1
Antoine Labour
lgtm
4 years, 7 months ago (2016-04-28 18:43:29 UTC) #4
David Yen
On 2016/04/28 18:43:29, Antoine Labour wrote: > lgtm I think you used the wrong account ...
4 years, 7 months ago (2016-04-28 18:45:15 UTC) #5
piman
lgtm
4 years, 7 months ago (2016-04-28 18:46:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924353002/1
4 years, 7 months ago (2016-04-28 18:51:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 21:11:02 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:21:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46893a3125cca64012e98924ecd93756841f2c98
Cr-Commit-Position: refs/heads/master@{#390484}

Powered by Google App Engine
This is Rietveld 408576698