components/cast_certificate/cast_cert_validator_test_helpers.h - Issue 1924323002: Move Cast certificate verification code from extensions to components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cast_certificate/cast_cert_validator_test_helpers.h

Issue 1924323002: Move Cast certificate verification code from extensions to components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cast_certificate/cast_cert_validator.h ('K') | « components/cast_certificate/cast_cert_validator.cc ('k') | components/cast_certificate/cast_cert_validator_test_helpers.cc » ('j') | components/test/data/cast_certificate/signeddata/2ZZBG9_FA8FCA3EF91A.pem » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cast_certificate/cast_cert_validator_test_helpers.h

diff --git a/extensions/common/cast/cast_cert_validator_test_helpers.h b/components/cast_certificate/cast_cert_validator_test_helpers.h

similarity index 87%

rename from extensions/common/cast/cast_cert_validator_test_helpers.h

rename to components/cast_certificate/cast_cert_validator_test_helpers.h

index dad622810412bc519497c81b7b370b1dd69dfc88..8b7efec50a31d8b28a25c97d67c258e71381d07c 100644

--- a/extensions/common/cast/cast_cert_validator_test_helpers.h

+++ b/components/cast_certificate/cast_cert_validator_test_helpers.h

@@ -13,7 +13,7 @@

namespace cast_test_helpers {

eroman 2016/04/28 19:50:20 This should probably be inside the cast_certificat

ryanchung 2016/04/28 20:30:56 Done.

// Reads a PEM file containing certificates to a vector of their DER data.

-// |file_name| should be relative to //src/extensions/test/data/

+// |file_name| should be relative to //components/test/data/cast_certificate

std::vector<std::string> ReadCertificateChainFromFile(

const base::StringPiece& file_name);

@@ -30,7 +30,7 @@ struct SignatureTestData {

// Reads a PEM file that contains "MESSAGE", "SIGNATURE SHA1" and

// "SIGNATURE SHA256" blocks.

-// |file_name| should be relative to //src/extensions/test/data/

+// |file_name| should be relative to //components/test/data/cast_certificate

SignatureTestData ReadSignatureTestData(const base::StringPiece& file_name);

} // namespace cast_test_helpers