Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 1924313002: Make <attr-name> accept any CSS identifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/attr-parsing-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
index f25aebc84142ae33997e98f3cb8c3b3f22931ce5..cec9bbd85a1f572b1fc59f9abf1c26bbaa72fd5c 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
@@ -2326,11 +2326,7 @@ static CSSValue* consumeAttr(CSSParserTokenRange args, CSSParserContext context)
return nullptr;
String attrName = args.consumeIncludingWhitespace().value();
- // CSS allows identifiers with "-" at the start, like "-webkit-mask-image".
- // But HTML attribute names can't have those characters, and we should not
- // even parse them inside attr().
- // TODO(timloh): We should allow any <ident-token> here.
- if (attrName[0] == '-' || !args.atEnd())
+ if (!args.atEnd())
return nullptr;
if (context.isHTMLDocument())
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/attr-parsing-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698