test/cctest/wasm/test-wasm-stack.cc - Issue 1924253002: [wasm] Patch trapping position into stack trace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/wasm/test-wasm-stack.cc

Issue 1924253002: [wasm] Patch trapping position into stack trace (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@pass-wasm-position-to-runtime

Patch Set: add TODO with tracking bug Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/wasm/test-wasm-stack.cc

diff --git a/test/cctest/wasm/test-wasm-stack.cc b/test/cctest/wasm/test-wasm-stack.cc

index d32a2efb39c0001b50f9faa9025d1d319e66e9a5..b6cd674fbc96185f8cdac4e48630fa30edf106a0 100644

--- a/test/cctest/wasm/test-wasm-stack.cc

+++ b/test/cctest/wasm/test-wasm-stack.cc

@@ -157,8 +157,7 @@ TEST(CollectDetailedWasmStack_WasmError) {

// Line number is 1-based, with 0 == kNoLineNumberInfo.

ExceptionInfo expected_exceptions[] = {

- // TODO(clemens): position should be 1

- {"<WASM>", static_cast<int>(wasm_index), -1}, // -

+ {"<WASM>", static_cast<int>(wasm_index), 1}, // -

{"<WASM>", static_cast<int>(wasm_index_2), 1}, // -

{"callFn", 1, 24} //-

};

« no previous file with comments | « test/cctest/cctest.gyp ('k') | test/cctest/wasm/test-wasm-trap-position.cc » ('j') | no next file with comments »