Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1924233002: Turn Array.isArray into a Turbofan stub (Closed)

Created:
4 years, 7 months ago by Toon Verwaest
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn Array.isArray into a Turbofan stub The current stub supports everything except JSProxy BUG= Committed: https://crrev.com/49a4f2d14ab4994425e2d7d261db1f4b1b24c47e Cr-Commit-Position: refs/heads/master@{#35891}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -12 lines) Patch
M src/builtins.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/builtins.cc View 2 chunks +33 lines, -10 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 2 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Toon Verwaest
ptal
4 years, 7 months ago (2016-04-28 09:49:57 UTC) #2
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-04-28 09:52:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924233002/20001
4 years, 7 months ago (2016-04-28 09:54:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/4977) v8_linux64_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-04-28 10:13:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924233002/40001
4 years, 7 months ago (2016-04-29 07:38:07 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-29 08:17:29 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:19 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/49a4f2d14ab4994425e2d7d261db1f4b1b24c47e
Cr-Commit-Position: refs/heads/master@{#35891}

Powered by Google App Engine
This is Rietveld 408576698