Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 1924203004: Implement arflags in the GN build. (Closed)

Created:
4 years, 7 months ago by brettw
Modified:
4 years, 7 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement arflags in the GN build. This flag was recently added in GN. This patch hooks it up to the toolchains and moves some flags to use it that previously had to be hardcoded on the tool command itself. Clarifies usage of concurrent_links variable in gcc_toolchain which was confusing. TBR=brucedawson@chromium.org BUG=598599 Reland of http://crrev.com/1909163002 with fixes which was a reland of http://crrev.com/1896163003 with fix. Committed: https://crrev.com/5404cdff57233dbad6e0b20afd547e445c57cd23 Cr-Commit-Position: refs/heads/master@{#390797}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -14 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M build/config/posix/BUILD.gn View 2 chunks +16 lines, -0 lines 0 comments Download
M build/config/win/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 3 chunks +8 lines, -12 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/win/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
brettw
The OOM errors on Android debug bots were a result of too many concurrent links. ...
4 years, 7 months ago (2016-04-29 22:10:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924203004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924203004/20001
4 years, 7 months ago (2016-04-29 22:11:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 23:10:49 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:29:59 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5404cdff57233dbad6e0b20afd547e445c57cd23
Cr-Commit-Position: refs/heads/master@{#390797}

Powered by Google App Engine
This is Rietveld 408576698