Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1924193002: [Fetch API] Abort fetching when the passed ScriptState is invalid. (Closed)

Created:
4 years, 7 months ago by yhirano
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Fetch API] Abort fetching when the passed ScriptState is invalid. Sometimes GlobalFetch::fetch is called with an invalid ScriptState. Do not start fetching in such a case. BUG=607156 Committed: https://crrev.com/582f4114bc1bfc048633ea00172b9d0871ed9d8a Cr-Commit-Position: refs/heads/master@{#390338}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
yhirano
4 years, 7 months ago (2016-04-28 05:50:18 UTC) #3
tyoshino (SeeGerritForStatus)
lgtm
4 years, 7 months ago (2016-04-28 06:48:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924193002/20001
4 years, 7 months ago (2016-04-28 07:08:16 UTC) #6
haraken
LGTM
4 years, 7 months ago (2016-04-28 07:31:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 10:15:51 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:17 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/582f4114bc1bfc048633ea00172b9d0871ed9d8a
Cr-Commit-Position: refs/heads/master@{#390338}

Powered by Google App Engine
This is Rietveld 408576698