Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1924173004: Switch ClangToTLinuxASan from gyp to gn. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
hans, Dirk Pranke
CC:
chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch ClangToTLinuxASan from gyp to gn. The other two ClangToTLinux bots are blocked on other things happening first (ubsan tests aren't green in gn builds yet, crbug.com/606003, and gn doesn't have linux_dump_symbols yet, crbug.com/605819) BUG=605732 Committed: https://crrev.com/09aef466c98076fcccb2e8cd3903f05c4348bf83 Cr-Commit-Position: refs/heads/master@{#390676}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 13 (4 generated)
Nico
(krasin is looking at the ubsan thing, and i'll look at linux_dump_symbols after moving all ...
4 years, 7 months ago (2016-04-29 15:58:01 UTC) #2
hans
lgtm, let's try it
4 years, 7 months ago (2016-04-29 16:01:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924173004/1
4 years, 7 months ago (2016-04-29 16:02:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 16:59:18 UTC) #6
Dirk Pranke
https://codereview.chromium.org/1924173004/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1924173004/diff/1/tools/mb/mb_config.pyl#newcode135 tools/mb/mb_config.pyl:135: 'ClangToTLinuxASan': 'swarming_clang_tot_asan_lsan_static_release', nit: I'm not sure why you didn't ...
4 years, 7 months ago (2016-04-29 17:58:24 UTC) #8
Dirk Pranke
lgtm
4 years, 7 months ago (2016-04-29 17:58:34 UTC) #9
Nico
On 2016/04/29 17:58:24, Dirk Pranke wrote: > https://codereview.chromium.org/1924173004/diff/1/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): > > https://codereview.chromium.org/1924173004/diff/1/tools/mb/mb_config.pyl#newcode135 ...
4 years, 7 months ago (2016-04-29 18:38:04 UTC) #10
Nico
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1932333002/ by thakis@chromium.org. ...
4 years, 7 months ago (2016-04-29 18:38:37 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:26:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09aef466c98076fcccb2e8cd3903f05c4348bf83
Cr-Commit-Position: refs/heads/master@{#390676}

Powered by Google App Engine
This is Rietveld 408576698