Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1924163003: Fixed scrolling for mixed-valuator mouse (Closed)

Created:
4 years, 7 months ago by dtapuska
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fixed scrolling for mixed-valuator mouse I fixed scrolling for the case when a mouse only has a scroll valuator for one of its axes; this is done by first making GetScrollOffsetsFromXEvent only return true when an actual smooth scroll event is being processed, and secondly by adding a second check that disables legacy scroll events if the device could have outputted a valuator event. BUG=596013 Review URL: https://codereview.chromium.org/1891303002 Cr-Commit-Position: refs/heads/master@{#389059} (cherry picked from commit 1517f16eda05f6cbec46cb9efdf806ce7ed2240c) Committed: https://chromium.googlesource.com/chromium/src/+/6433bb28a72791a3ab62e854b4b16a5cdd03db2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M ui/events/x/events_x_utils.cc View 2 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 7 months ago (2016-04-28 20:50:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6433bb28a72791a3ab62e854b4b16a5cdd03db2f.

Powered by Google App Engine
This is Rietveld 408576698