Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1924153002: DevTools: reorder items in the resources panel sidebar (Closed)

Created:
4 years, 7 months ago by pfeldman
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, michaeln, caseq+blink_chromium.org, tfarina, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: reorder items in the resources panel sidebar BUG=607366 Committed: https://crrev.com/f07a495565b4bac1b89ce8bef1711607cce8b366 Cr-Commit-Position: refs/heads/master@{#390282}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -310 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/appcache/appcache-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resource-tree-frame-add-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resource-tree-frame-navigate-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resource-tree-htmlimports-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resource-tree-reload-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-redundant.html View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-view.html View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-view-expected.txt View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js View 1 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js View 1 17 chunks +62 lines, -134 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/resourcesPanel.css View 6 chunks +3 lines, -140 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css View 1 chunk +148 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/serviceWorkersView.css View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pfeldman
4 years, 7 months ago (2016-04-28 01:07:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924153002/1
4 years, 7 months ago (2016-04-28 01:11:15 UTC) #4
dgozman
lgtm https://codereview.chromium.org/1924153002/diff/20001/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js (right): https://codereview.chromium.org/1924153002/diff/20001/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js#newcode2054 third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:2054: return "appcache://" + this._manifestURL + "/" + encodeURI(this.titleAsText()); ...
4 years, 7 months ago (2016-04-28 01:44:59 UTC) #5
pfeldman
On 2016/04/28 01:44:59, dgozman wrote: > lgtm > > https://codereview.chromium.org/1924153002/diff/20001/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js > File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js > (right): ...
4 years, 7 months ago (2016-04-28 01:48:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924153002/20001
4 years, 7 months ago (2016-04-28 01:48:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 03:04:45 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:15:45 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f07a495565b4bac1b89ce8bef1711607cce8b366
Cr-Commit-Position: refs/heads/master@{#390282}

Powered by Google App Engine
This is Rietveld 408576698