Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1924133002: Rename gfx::Display/Screen to display::Display/Screen in extensions (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gfx::Display/Screen to display::Display/Screen in extensions BUG=597761 Committed: https://crrev.com/9dff30e370f8b3a4c79da7be451a0466499f9b9f Cr-Commit-Position: refs/heads/master@{#390275}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -91 lines) Patch
M extensions/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/system_display/display_info_provider.h View 3 chunks +7 lines, -3 lines 0 comments Download
M extensions/browser/api/system_display/display_info_provider.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M extensions/browser/api/system_display/system_display_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/system_display/system_display_apitest.cc View 6 chunks +23 lines, -21 lines 0 comments Download
M extensions/browser/api/system_info/system_info_api.cc View 6 chunks +16 lines, -13 lines 0 comments Download
M extensions/browser/api/web_contents_capture_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/app_window/app_window.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_display_info_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_display_info_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_screen.h View 3 chunks +14 lines, -12 lines 0 comments Download
M extensions/shell/browser/shell_screen.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M extensions/shell/browser/shell_screen_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924133002/20001
4 years, 7 months ago (2016-04-27 23:55:12 UTC) #5
oshima
4 years, 7 months ago (2016-04-28 00:10:09 UTC) #8
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-04-28 00:17:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924133002/20001
4 years, 7 months ago (2016-04-28 00:17:56 UTC) #12
commit-bot: I haz the power
Failed to apply the patch.
4 years, 7 months ago (2016-04-28 02:02:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924133002/20001
4 years, 7 months ago (2016-04-28 04:22:22 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/174473)
4 years, 7 months ago (2016-04-28 04:29:22 UTC) #19
oshima
On 2016/04/28 04:29:22, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 7 months ago (2016-04-28 04:52:10 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:15:34 UTC) #21
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9dff30e370f8b3a4c79da7be451a0466499f9b9f
Cr-Commit-Position: refs/heads/master@{#390275}

Powered by Google App Engine
This is Rietveld 408576698